From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: zap cache status enable and disable functions
Date: Fri, 9 Oct 2015 14:57:00 +0200 [thread overview]
Message-ID: <201510091457.00490.marex@denx.de> (raw)
In-Reply-To: <1444361567-27328-1-git-send-email-thomas@wytron.com.tw>
On Friday, October 09, 2015 at 05:32:47 AM, Thomas Chou wrote:
> As the icache and dcache of nios2 are always enabled, the
> cmd_cache is no of use and the cache status, enable and
> disable functions can be removed.
This is no good, I want to be able to enable/disable caches to look
for DMA-related issues. That is, if I disable cache, the suspicious
driver works and if I enable cache, the driver does not work, I can
conclude that it's a DMA/cache-related issue.
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> arch/nios2/cpu/cpu.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/arch/nios2/cpu/cpu.c b/arch/nios2/cpu/cpu.c
> index 229a07b..4183244 100644
> --- a/arch/nios2/cpu/cpu.c
> +++ b/arch/nios2/cpu/cpu.c
> @@ -29,21 +29,6 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char
> * const argv[]) return 0;
> }
>
> -int dcache_status(void)
> -{
> - return 1;
> -}
> -
> -void dcache_enable(void)
> -{
> - flush_dcache(CONFIG_SYS_DCACHE_SIZE, CONFIG_SYS_DCACHELINE_SIZE);
> -}
> -
> -void dcache_disable(void)
> -{
> - flush_dcache(CONFIG_SYS_DCACHE_SIZE, CONFIG_SYS_DCACHELINE_SIZE);
> -}
> -
> int arch_cpu_init_dm(void)
> {
> struct udevice *dev;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-10-09 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 3:32 [U-Boot] [PATCH] nios2: zap cache status enable and disable functions Thomas Chou
2015-10-09 12:57 ` Marek Vasut [this message]
2015-10-10 7:38 ` Thomas Chou
2015-10-10 18:10 ` Marek Vasut
2015-10-13 13:19 ` Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510091457.00490.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox