public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] nios2: convert copy_exception_trampoline to use dm cpu data
Date: Fri, 9 Oct 2015 16:48:39 +0200	[thread overview]
Message-ID: <201510091648.39727.marex@denx.de> (raw)
In-Reply-To: <56177EC4.80103@wytron.com.tw>

On Friday, October 09, 2015 at 10:45:56 AM, Thomas Chou wrote:
> Hi Ley Foon,
> 
> On 10/09/2015 10:51 AM, Ley Foon Tan wrote:
> >> +static void copy_exception_trampoline(void)
> >> +{
> >> +       extern int _except_start, _except_end;
> > 
> > Can we use void* for _except_start and _except_end?
> 
> Yes, we can. Actually I used void * at first draft of this patch v1. But
> it doesn't work. We still need to get the address with '&' operator as
> in v2. I think it is confusing with void *, so I use int instead. But
> anything will do.

I think extern void * might work, but extern int is also OK when referencing
external symbol.

Best regards,
Marek Vasut

  reply	other threads:[~2015-10-09 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05  3:39 [U-Boot] [PATCH] nios2: convert copy_exception_trampoline to use dm cpu data Thomas Chou
2015-10-06  6:55 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-10-08 21:41   ` Marek Vasut
2015-10-09  2:51   ` Ley Foon Tan
2015-10-09  8:45     ` Thomas Chou
2015-10-09 14:48       ` Marek Vasut [this message]
2015-10-13 13:16   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201510091648.39727.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox