[U-Boot] [PATCH] nios2: convert cache flush to use dm cpu data

Wolfgang Denk
2015-10-12T13:49:29Z

Dear Marek,

In message <201510121529.45730.marex@denx.de> you wrote:
>
> That is bad bad bad, that's even nastier. We really need to fix the drivers,
> not paper over it in the cache ops.

Full ACK here.

> > To solve problem like this, the only solution is to enforce the rule to
> > allocate DMA buffer. It is wrong to skip the flush.
>
> I absolutelly agree we need aligned allocations for DMA memory areas. But,
> we also shouldn't hide bugs. And I believe aligning the incorrect arguments
> to cache functions is not the way to go. We should check the arguments and
> if someone tries an unaligned cache op, we should scream. What do you think?

Again, full ACK.

We should make sure we get clear, unmistakable error messages for such
bugs, and not silent non-deterministic behaviour.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There you go man, Keep as cool as you can. It riles them to believe
that you perceive the web they weave. Keep on being free!