U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/image.c: Make boot_get_ramdisk() perform a check for Android images
Date: Sun, 11 Oct 2015 09:09:47 -0400	[thread overview]
Message-ID: <20151011130947.GZ3829@bill-the-cat> (raw)
In-Reply-To: <CAL_Jsq+BcgYor+38GMu9Q=1EtVOSw3fK+wrx2kVP1UG_hiDUzw@mail.gmail.com>

On Mon, Oct 05, 2015 at 02:23:40PM -0500, Rob Herring wrote:
> On Tue, Sep 1, 2015 at 8:50 AM, Paul Kocialkowski <contact@paulk.fr> wrote:
> > Le jeudi 27 ao?t 2015 ? 15:42 -0400, Tom Rini a ?crit :
> >> In 2dd4632 the check for where a ramdisk is found on an Android image
> >> was got moved into the "normal" loop here, causing people to have to
> >> pass the kernel address in the ramdisk address location in order to have
> >> Android boot still.  This changed previous behavior so perform a check
> >> early in the function to see if we have an Android image and if so use
> >> that as where to look for the ramdisk (which is what the rest of the
> >> code here expects).
> >
> > That patch does fix my problem (the ramdisk is now correctly passed to
> > the kernel). I suggest that you merge it ASAP.
> 
> Doesn't look like this was ever merged or respun. I had some comments,
> but have no issue if they addressed separately as part of some
> refactoring.

OK.  With respect to the code flow, that's on the "someday, probably"
list.  I've shuffled things around so that you can still provide a
separate ramdisk to override the image as that was the use-case I hadn't
considered before.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151011/45cd43e2/attachment.sig>

  parent reply	other threads:[~2015-10-11 13:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 19:42 [U-Boot] [PATCH] common/image.c: Make boot_get_ramdisk() perform a check for Android images Tom Rini
2015-08-27 21:04 ` Rob Herring
2015-08-27 21:47   ` Tom Rini
2015-08-28 15:35     ` Rob Herring
2015-08-28 16:24       ` Tom Rini
2015-09-01 13:50 ` Paul Kocialkowski
2015-10-05 19:23   ` Rob Herring
2015-10-07 18:07     ` Paul Kocialkowski
2015-10-10 13:10       ` Paul Kocialkowski
2015-10-11 13:09     ` Tom Rini [this message]
2015-10-12 15:15 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151011130947.GZ3829@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox