From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 12 Oct 2015 13:56:56 -0400 Subject: [U-Boot] [U-Boot,v4,02/10] vexpress64: Kconfig: tidy up In-Reply-To: References: <1444407488-32646-3-git-send-email-ryan.harkin@linaro.org> <20151012151729.GX23893@bill-the-cat> Message-ID: <20151012175656.GO23893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Oct 12, 2015 at 05:47:20PM +0100, Ryan Harkin wrote: > Hi Tom, > > On 12 October 2015 at 16:17, Tom Rini wrote: > > > On Fri, Oct 09, 2015 at 05:18:00PM +0100, Ryan Harkin wrote: > > > > > The FVP and Juno settings were identical, but duplicated, so I removed > > > the duplication with this patch. > > > > > > Signed-off-by: Ryan Harkin > > > Reviewed-by: Linus Walleij > > > > Applied to u-boot/master, thanks! > > > > Thanks for applying my series! > > > > But note that I had to "dirty" up the Kconfig file a bit to not break > > other boards. > > > I'm sorry about that. I had to look, but now I see that arch/arm/Kconfig > is unconditionally including that Kconfig, which I hadn't realised. So here's a thing that buildman can really help with. With just: $ cat ~/.buildman [toolchain] aarch64: /opt/linaro/gcc-linaro-aarch64-linux-gnu-4.8-2013.10_linux (Aside: I should get a newer aarch64 toolchain, I know..) you can do: $ ./tools/buildman/buildman aarch64 And that will build not just the vexpress64 things but everything aarch64 and that's a small enough subset of boards to not be a "heavy" thing to do prior to submitting patches but wide enough to catch problems like this :) > > I suspect you want to make more clean-ups and model on > > say ARCH_UNIPHIER stuff instead. > > > > Thanks, I'll check that out. A quick look shows that it seems to cover > multiple similar platforms quite well. Yeah. And related, is TARGET_VEXPRESS64_AEMV8A intended to be something like that really? There's no defconfig for "just" that today. I'm guessing it should become ARCH_VEXPRESS64_AEMV8A (or so..) and then further shuffle code and Kconfigs around. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: