From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 18 Oct 2015 18:36:21 +0200 Subject: [U-Boot] [PATCH v3 7/8] zynq: Move SPL console init out of board_init_f() In-Reply-To: <1445116021-27296-8-git-send-email-sjg@chromium.org> References: <1445116021-27296-1-git-send-email-sjg@chromium.org> <1445116021-27296-8-git-send-email-sjg@chromium.org> Message-ID: <20151018183621.6dbad57b@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On Sat, 17 Oct 2015 15:07:00 -0600, Simon Glass wrote: > We should not init the console this early and there is no need to. If we want > to do early init it can be done in spl_board_init(). Move the > preloader_console_init() call from board_init_f() to board_init_r(). > > Signed-off-by: Simon Glass > Tested-by: Masahiro Yamada > Tested-by: Michal Simek I personally think that we should, almost must in fact, initialize the console as early as possible. What exactly is the drawaback of initializing the console here? Amicalement, -- Albert.