From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 05/10] fat: ff: read max contiguous file data
Date: Tue, 20 Oct 2015 15:10:21 -0400 [thread overview]
Message-ID: <20151020191021.GS23893@bill-the-cat> (raw)
In-Reply-To: <56268E9C.6080803@wwwdotorg.org>
On Tue, Oct 20, 2015 at 12:57:32PM -0600, Stephen Warren wrote:
> On 10/02/2015 12:06 AM, Stephen Warren wrote:
> >Enhance f_read() to find the maximum contiguous set of clusters to read,
> >and read it all at once (which is fast) rather one by one (which is
> >slow).
>
> Hmm. I had hoped that the author of ff.c would accept this patch
> upstream, so we could pick up a later upstream version that included
> this patch. However, it seems the author of ff.c has a policy of not
> accepting outside contributions:
>
> http://elm-chan.org/fsw/ff/bd/?show=2472
> (That's a link to the author's reply to my patch, on the forum
> system associated with his/her SW)
The bit about the license is at
http://elm-chan.org/fsw/ff/en/appnote.html#license
> I wonder how much of a liability incorporating ff.c into U-Boot will
> be, if we can't ever get any fixes merged upstream. Perhaps we just
> fork it, although I had hoped we'd be able to keep picking up new
> versions.
Arg, that really does take away one of the potential nice features. I
guess, sadly, at this point I'd rather stick with the version we have
unless you want to deal with re-syncing their releases but still
effectively doing a fork (so that we can also make use of caches which I
think you said before you thought might be part of the performance
problem.
Or we take a look at borrowing the kernel's code, similar to how we
leverage UBIFS today.
Regardless, thanks for the time you've already put in on this!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151020/8ecda3e0/attachment.sig>
next prev parent reply other threads:[~2015-10-20 19:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 6:06 [U-Boot] [PATCH V3 01/10] disk: support host devices in dev_print() Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 02/10] fat: move to a different directory Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 03/10] fat: add ff.c implementation Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 04/10] fat: ff: add ifdef to avoid unused function warning Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 05/10] fat: ff: read max contiguous file data Stephen Warren
2015-10-20 18:57 ` Stephen Warren
2015-10-20 19:10 ` Tom Rini [this message]
2015-10-20 20:40 ` Stephen Warren
2019-05-17 23:03 ` Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 06/10] fat: ffconf.h changes for U-Boot port Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 07/10] fat: port integer.h to U-Boot types Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 08/10] fat: add U-Boot to ff.c API conversion wrapper Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 09/10] fat: switch to new FAT implementation Stephen Warren
2015-10-02 6:06 ` [U-Boot] [PATCH V3 10/10] fat: remove old implementation Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020191021.GS23893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox