From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 20 Oct 2015 15:46:36 -0400 Subject: [U-Boot] [PATCH v2 09/14] fastboot: Implement NAND backend In-Reply-To: <1444912462-3949-10-git-send-email-maxime.ripard@free-electrons.com> References: <1444912462-3949-1-git-send-email-maxime.ripard@free-electrons.com> <1444912462-3949-10-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <20151020194636.GD23893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Oct 15, 2015 at 02:34:17PM +0200, Maxime Ripard wrote: > So far the fastboot code was only supporting MMC-backed devices for its > flashing operations (flash and erase). > > Add a storage backend for NAND-backed devices. > > Signed-off-by: Maxime Ripard This is mutually exclusive with MMC support, right? If so, it's not quite written that way in the #ifdef's so I think it need to be down in say: > @@ -569,6 +572,11 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req) > (void *)CONFIG_FASTBOOT_BUF_ADDR, > download_bytes, response); > #endif > +#ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV > + fb_nand_flash_write(cmd, fastboot_flash_session_id, > + (void *)CONFIG_FASTBOOT_BUF_ADDR, > + download_bytes, response); > +#endif With #elif/#error "Fastboot enabled but without any backing store support" and we drop the #error once this is Kconfig'zied. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: