From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 21 Oct 2015 00:31:20 +0200 Subject: [U-Boot] [PATCH] ohci: Add missing cache-flush for hcca area In-Reply-To: <1445359169-28875-1-git-send-email-hdegoede@redhat.com> References: <1445359169-28875-1-git-send-email-hdegoede@redhat.com> Message-ID: <201510210031.20451.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, October 20, 2015 at 06:39:29 PM, Hans de Goede wrote: > We need to cache-flush the hcca area after the initial memset, otherwise > on the first hc_interrupt we might see an old $random value as done_head > and try to interpret that as the address for a completed td (followed by > chaos). > > Signed-off-by: Hans de Goede Dang, this came three hours after the release of 2015.10 ;-) Oh well. Applied, thanks! > --- > drivers/usb/host/ohci-hcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c > index 9bde2b2..ccbfc02 100644 > --- a/drivers/usb/host/ohci-hcd.c > +++ b/drivers/usb/host/ohci-hcd.c > @@ -2205,6 +2205,7 @@ int ohci_register(struct udevice *dev, struct > ohci_regs *regs) if (!ohci->hcca) > return -ENOMEM; > memset(ohci->hcca, 0, sizeof(struct ohci_hcca)); > + flush_dcache_hcca(ohci->hcca); > > if (hc_reset(ohci) < 0) > return -EIO; Best regards, Marek Vasut