From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 09/14] fastboot: Implement NAND backend
Date: Wed, 21 Oct 2015 16:49:04 -0400 [thread overview]
Message-ID: <20151021204904.GS23893@bill-the-cat> (raw)
In-Reply-To: <20151021145704.GG10947@lukather>
On Wed, Oct 21, 2015 at 04:57:04PM +0200, Maxime Ripard wrote:
> Hi Tom,
>
> On Tue, Oct 20, 2015 at 03:46:36PM -0400, Tom Rini wrote:
> > On Thu, Oct 15, 2015 at 02:34:17PM +0200, Maxime Ripard wrote:
> >
> > > So far the fastboot code was only supporting MMC-backed devices for its
> > > flashing operations (flash and erase).
> > >
> > > Add a storage backend for NAND-backed devices.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >
> > This is mutually exclusive with MMC support, right? If so, it's not
> > quite written that way in the #ifdef's so I think it need to be down in
> > say:
> >
> > > @@ -569,6 +572,11 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req)
> > > (void *)CONFIG_FASTBOOT_BUF_ADDR,
> > > download_bytes, response);
> > > #endif
> > > +#ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV
> > > + fb_nand_flash_write(cmd, fastboot_flash_session_id,
> > > + (void *)CONFIG_FASTBOOT_BUF_ADDR,
> > > + download_bytes, response);
> > > +#endif
> >
> > With #elif/#error "Fastboot enabled but without any backing store
> > support" and we drop the #error once this is Kconfig'zied.
>
> We said in the precedent version that the end goal would be to support
> both at the same time, if relevant.
>
> I was willing to treat that as a followup patch, but I guess I should
> do as you suggest for the time being.
Yeah, we want to make sure that until it's supported it can't be
configured to try and do it.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151021/562f4df1/attachment.sig>
next prev parent reply other threads:[~2015-10-21 20:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:34 [U-Boot] [PATCH v2 00/14] Implement fastboot over NAND and sparse transfers Maxime Ripard
2015-10-15 12:34 ` [U-Boot] [PATCH v2 01/14] mtd: uboot: Add meaningful error message Maxime Ripard
2015-11-13 1:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 02/14] sparse: Move main header parsing to a function of its own Maxime Ripard
2015-11-13 1:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 03/14] sparse: Refactor chunk parsing function Maxime Ripard
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 04/14] sparse: Simplify multiple logic Maxime Ripard
2015-10-20 19:39 ` Tom Rini
2015-11-13 1:27 ` [U-Boot] [U-Boot,v2,04/14] " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 05/14] fastboot: Move fastboot response functions to fastboot core Maxime Ripard
2015-10-20 19:40 ` Tom Rini
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 06/14] sparse: Implement storage abstraction Maxime Ripard
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 07/14] fastboot: Implement flashing session counter Maxime Ripard
2015-10-20 19:41 ` Tom Rini
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 08/14] sparse: Implement several chunks flashing Maxime Ripard
2015-10-20 19:47 ` Tom Rini
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 09/14] fastboot: Implement NAND backend Maxime Ripard
2015-10-20 19:46 ` Tom Rini
2015-10-21 14:57 ` Maxime Ripard
2015-10-21 20:49 ` Tom Rini [this message]
2015-11-13 1:27 ` [U-Boot] [U-Boot,v2,09/14] " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 10/14] fastboot: nand: Add pre erase and write hooks Maxime Ripard
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 11/14] sparse: Rename the file and header Maxime Ripard
2015-10-20 19:46 ` Tom Rini
2015-11-13 1:27 ` [U-Boot] [U-Boot,v2,11/14] " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 12/14] sunxi: Add support for android boot image Maxime Ripard
2015-10-15 18:42 ` Ian Campbell
2015-10-15 12:34 ` [U-Boot] [PATCH v2 13/14] sunxi: A13-Olinuxino: Enable the USB OTG controller Maxime Ripard
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-15 12:34 ` [U-Boot] [PATCH v2 14/14] sunxi: cubietruck: " Maxime Ripard
2015-11-13 1:27 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-17 13:59 ` [U-Boot] [PATCH v2 00/14] Implement fastboot over NAND and sparse transfers Hans de Goede
2015-10-17 14:42 ` Hans de Goede
2015-10-19 8:17 ` Maxime Ripard
2015-10-20 19:32 ` Tom Rini
2015-10-20 19:38 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021204904.GS23893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox