From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/8] Move board_init_f_mem() into a common location
Date: Thu, 22 Oct 2015 07:53:55 +0200 [thread overview]
Message-ID: <20151022075355.5d29a9e8@lilith> (raw)
In-Reply-To: <1445259003-15896-2-git-send-email-sjg@chromium.org>
Hello Simon,
On Mon, 19 Oct 2015 06:49:56 -0600, Simon Glass <sjg@chromium.org>
wrote:
> This function will be used by both SPL and U-Boot proper. So move it into
> a common place. Also change the #ifdef so that the early malloc() area is
> not set up in SPL if CONFIG_SYS_SPL_MALLOC_START is defined. In that case
> it would never actually be used, and just chews up stack space.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> diff --git a/common/Makefile b/common/Makefile
> index 491c565..e2f9401 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -7,6 +7,7 @@
>
> # core
> ifndef CONFIG_SPL_BUILD
> +obj-y += init/
I'm certainly missing something, even if only a comment in the file
or note in the commit: why is this under ifndef CONFIG_SPL_BUILD (and
thus won't build with SPL) when the file init/board_init.c is supposed
to be "Code shared between SPL and U-Boot proper"?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-10-22 5:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:49 [U-Boot] [PATCH v4 0/8] arm: Tidy up early init Simon Glass
2015-10-19 12:49 ` [U-Boot] [PATCH v4 1/8] Move board_init_f_mem() into a common location Simon Glass
2015-10-22 5:53 ` Albert ARIBAUD [this message]
2015-10-24 21:15 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:49 ` [U-Boot] [PATCH v4 2/8] board_init_f_mem(): Don't require memset() Simon Glass
2015-10-24 21:15 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:49 ` [U-Boot] [PATCH v4 3/8] board_init_f_mem(): Don't create an unused early malloc() area Simon Glass
2015-10-24 21:15 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:49 ` [U-Boot] [PATCH v4 4/8] arm: Switch aarch64 to using generic global_data setup Simon Glass
2015-10-24 21:16 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:50 ` [U-Boot] [PATCH v4 5/8] arm: Switch 32-bit ARM " Simon Glass
2015-10-24 21:16 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:50 ` [U-Boot] [PATCH v4 6/8] microblaze: Add a TODO to call board_init_f_mem() Simon Glass
2015-10-24 21:16 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:50 ` [U-Boot] [PATCH v4 7/8] zynq: Move SPL console init out of board_init_f() Simon Glass
2015-10-24 21:16 ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-10-19 12:50 ` [U-Boot] [PATCH v4 8/8] Revert "ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot" Simon Glass
2015-10-24 21:16 ` [U-Boot] [U-Boot, v4, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022075355.5d29a9e8@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox