From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Thu, 22 Oct 2015 07:53:55 +0200
Subject: [U-Boot] [PATCH v4 1/8] Move board_init_f_mem() into a common
	location
In-Reply-To: <1445259003-15896-2-git-send-email-sjg@chromium.org>
References: <1445259003-15896-1-git-send-email-sjg@chromium.org>
 <1445259003-15896-2-git-send-email-sjg@chromium.org>
Message-ID: <20151022075355.5d29a9e8@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Simon,

On Mon, 19 Oct 2015 06:49:56 -0600, Simon Glass <sjg@chromium.org>
wrote:
> This function will be used by both SPL and U-Boot proper. So move it into
> a common place. Also change the #ifdef so that the early malloc() area is
> not set up in SPL if CONFIG_SYS_SPL_MALLOC_START is defined. In that case
> it would never actually be used, and just chews up stack space.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

> diff --git a/common/Makefile b/common/Makefile
> index 491c565..e2f9401 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -7,6 +7,7 @@
>  
>  # core
>  ifndef CONFIG_SPL_BUILD
> +obj-y += init/

I'm certainly missing something, even if only a comment in the file
or note in the commit: why is this under ifndef CONFIG_SPL_BUILD (and
thus won't build with SPL) when the file init/board_init.c is supposed
to be "Code shared between SPL and U-Boot proper"?

Amicalement,
-- 
Albert.