From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: stm32f4: fix a bug when only first sector gets erased
Date: Thu, 22 Oct 2015 08:13:28 +0200 [thread overview]
Message-ID: <20151022081328.35d28b91@lilith> (raw)
In-Reply-To: <1445298105-25571-1-git-send-email-pftbest@gmail.com>
Hello Vadzim,
On Tue, 20 Oct 2015 02:41:44 +0300, Vadzim Dambrouski
<pftbest@gmail.com> wrote:
> flash_lock call is inside a for cycle, so after the first iteration flash
> is locked and no more sectors can be erased.
Nitpick: the commit summary explains the problem well, but not the
(admittedly) trivial solution; just add it:
flash_lock call is inside a for cycle, so after the first
iteration flash is locked and no more sectors can be erased.
Move flash_lock out of the loop.
> Signed-off-by: Vadzim Dambrouski <pftbest@gmail.com>
Amicalement,
--
Albert.
prev parent reply other threads:[~2015-10-22 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 23:41 [U-Boot] [PATCH 1/2] arm: stm32f4: fix a bug when only first sector gets erased Vadzim Dambrouski
2015-10-19 23:41 ` [U-Boot] [PATCH 2/2] arm: stm32f4: fix a bug when a random " Vadzim Dambrouski
2015-10-22 6:13 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022081328.35d28b91@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox