From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/3] mx7: psci: add basic psci support
Date: Thu, 22 Oct 2015 20:38:29 +0800 [thread overview]
Message-ID: <20151022123826.GA12330@shlinux2> (raw)
In-Reply-To: <CAOMZO5DQkHEkkbucvYY1CrjiZPTyDJG6Q_DRmZpiEh6j6fs9wA@mail.gmail.com>
On Thu, Oct 22, 2015 at 10:38:10AM -0200, Fabio Estevam wrote:
>On Thu, Oct 22, 2015 at 10:34 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
>
>> +/* enable all periherial can be access in nosec mode */
>> +static void init_csu(void)
>> +{
>> + int i = 0;
>> + for (i = 0; i < 64; i++)
>> + writel(0x00FF00FF, 0x303e0000 + i * 4);
>
>I have already commented about this on my previous review: these
>hardcoded numbers do not look fine.
Oh. I missed this part.
Will use macro for the two value.
Regards,
Peng.
--
next prev parent reply other threads:[~2015-10-22 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 12:34 [U-Boot] [PATCH V3 1/3] arm: discard relocation entries for secure text Peng Fan
2015-10-22 12:34 ` [U-Boot] [PATCH V3 2/3] mx7: psci: add basic psci support Peng Fan
2015-10-22 12:38 ` Fabio Estevam
2015-10-22 12:38 ` Peng Fan [this message]
2015-10-22 12:34 ` [U-Boot] [PATCH V3 3/3] imx: mx7: default enable non-secure mode Peng Fan
2015-10-22 14:48 ` Fabio Estevam
2015-10-22 15:29 ` Peng Fan
2015-10-22 15:32 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022123826.GA12330@shlinux2 \
--to=b51431@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox