From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Thu, 22 Oct 2015 20:38:29 +0800 Subject: [U-Boot] [PATCH V3 2/3] mx7: psci: add basic psci support In-Reply-To: References: <1445517279-4534-1-git-send-email-Peng.Fan@freescale.com> <1445517279-4534-2-git-send-email-Peng.Fan@freescale.com> Message-ID: <20151022123826.GA12330@shlinux2> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Oct 22, 2015 at 10:38:10AM -0200, Fabio Estevam wrote: >On Thu, Oct 22, 2015 at 10:34 AM, Peng Fan wrote: > >> +/* enable all periherial can be access in nosec mode */ >> +static void init_csu(void) >> +{ >> + int i = 0; >> + for (i = 0; i < 64; i++) >> + writel(0x00FF00FF, 0x303e0000 + i * 4); > >I have already commented about this on my previous review: these >hardcoded numbers do not look fine. Oh. I missed this part. Will use macro for the two value. Regards, Peng. --