From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 22 Oct 2015 09:49:37 -0400 Subject: [U-Boot] [PATCH 05/12] spl: mmc: get rid of #ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION check In-Reply-To: <20151022134047.GB27303@skynet> References: <1445515280-21389-1-git-send-email-nikita@compulab.co.il> <1445515280-21389-6-git-send-email-nikita@compulab.co.il> <5628DAE1.2060408@redhat.com> <20151022134047.GB27303@skynet> Message-ID: <20151022134937.GC23893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Oct 22, 2015 at 04:40:47PM +0300, Nikita Kiryanov wrote: > On Thu, Oct 22, 2015 at 02:47:29PM +0200, Hans de Goede wrote: > Hi Hans, > > Hi, > > > > On 22-10-15 14:01, Nikita Kiryanov wrote: > > >Implement defaults for the raw partition image loading so that the #ifdef > > >CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION in spl_mmc_load_image() will no > > >longer be necessary. > > > > > >This change makes it possible for mmc_load_image_raw_partition() and > > >mmc_load_image_raw_sector() to coexist. > > > > > >Signed-off-by: Nikita Kiryanov > > >Cc: Igor Grinberg > > >Cc: Paul Kocialkowski > > >Cc: Pantelis Antoniou > > >Cc: Tom Rini > > >Cc: Simon Glass > > > > Same remark as with the previous patch, I'm not happy to see all these > > patches removing #ifdef-s given that spl is severely size constrained > > on some devices (e.g. recently we had a patchset for the rockchip 3036, > > which has only 8k space for the SPL). > > > > And I really do not see a need for this, boards which want to use > > multiple methods can simple define the CONFIG_SPL_FOO for all of them. > > The goal of the first part of the series is to make the spl_mmc file > easier to maintain. I do not believe that the function stubs would add > much to the binary size, but if you're concerned about bloat, I can do > a buildman comparison. Please do. We want this to be as small a change in size as possible (and may be why we need to look harder at LTO). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: