public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/4] spi: Use BIT macro in spi/drivers/*
Date: Thu, 22 Oct 2015 20:15:56 +0200	[thread overview]
Message-ID: <201510222015.56659.marex@denx.de> (raw)
In-Reply-To: <1445535950-3473-3-git-send-email-jteki@openedev.com>

On Thursday, October 22, 2015 at 07:45:49 PM, Jagan Teki wrote:
> BIT macro used on drivers/spi/*
> 
> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31
> 
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Jagan Teki <jteki@openedev.com>

So, you're sending this horrid blob of changes instead of splitting them
into more managable parts, sigh. Moreover, I have a feeling this is a
change for the sake of changing something, not great. Also, you did not
describe how you performed this change -- was it done using some sort of
sed script or by hand ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-10-22 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 17:45 [U-Boot] [PATCH v3 1/4] spi: zynq_[q]spi: Use BIT macro Jagan Teki
2015-10-22 17:45 ` [U-Boot] [PATCH v3 2/4] spi: zynq_[q]spi: Use GENMASK macro Jagan Teki
2015-10-22 17:45 ` [U-Boot] [PATCH v3 3/4] spi: Use BIT macro in spi/drivers/* Jagan Teki
2015-10-22 18:15   ` Marek Vasut [this message]
2015-10-22 18:21     ` Jagan Teki
2015-10-22 19:05       ` Marek Vasut
2015-10-22 19:09         ` Jagan Teki
2015-10-22 20:14           ` Marek Vasut
2015-10-22 17:45 ` [U-Boot] [PATCH v3 4/4] spi: Use GENMASK instead of numeric hexcodes Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201510222015.56659.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox