From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 22 Oct 2015 20:15:56 +0200
Subject: [U-Boot] [PATCH v3 3/4] spi: Use BIT macro in spi/drivers/*
In-Reply-To: <1445535950-3473-3-git-send-email-jteki@openedev.com>
References: <1445535950-3473-1-git-send-email-jteki@openedev.com>
 <1445535950-3473-3-git-send-email-jteki@openedev.com>
Message-ID: <201510222015.56659.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, October 22, 2015 at 07:45:49 PM, Jagan Teki wrote:
> BIT macro used on drivers/spi/*
> 
> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31
> 
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Jagan Teki <jteki@openedev.com>

So, you're sending this horrid blob of changes instead of splitting them
into more managable parts, sigh. Moreover, I have a feeling this is a
change for the sake of changing something, not great. Also, you did not
describe how you performed this change -- was it done using some sort of
sed script or by hand ?

Best regards,
Marek Vasut