From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 22 Oct 2015 21:05:27 +0200 Subject: [U-Boot] [PATCH v3 3/4] spi: Use BIT macro in spi/drivers/* In-Reply-To: References: <1445535950-3473-1-git-send-email-jteki@openedev.com> <201510222015.56659.marex@denx.de> Message-ID: <201510222105.27493.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, October 22, 2015 at 08:21:29 PM, Jagan Teki wrote: > On 22 October 2015 at 23:45, Marek Vasut wrote: > > On Thursday, October 22, 2015 at 07:45:49 PM, Jagan Teki wrote: > >> BIT macro used on drivers/spi/* > >> > >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31 > >> > >> Cc: Tom Rini > >> Cc: Simon Glass > >> Cc: Masahiro Yamada > >> Cc: Peng Fan > >> Cc: Stefan Roese > >> Cc: Marek Vasut > >> Cc: Stephen Warren > >> Cc: Tom Warren > >> Signed-off-by: Jagan Teki > > > > So, you're sending this horrid blob of changes instead of splitting them > > into more managable parts, sigh. Moreover, I have a feeling this is a > > change for the sake of changing something, not great. Also, you did not > > describe how you performed this change -- was it done using some sort of > > sed script or by hand ? > > Yes this is performed using sed The script you used should be explained somewhere. > and as this a common change I have > combined all spi drivers as I belongs to - did you see any wrong on > this? It's hard to review such a big blob, furthermore if you need to adjust some driver, you'd have to repost this whole thing instead of a single patch. Best regards, Marek Vasut