[U-Boot] [PATCH v3 3/4] spi: Use BIT macro in spi/drivers/*

Marek Vasut
2015-10-22T20:14:14Z

On Thursday, October 22, 2015 at 09:09:43 PM, Jagan Teki wrote:
> On 23 October 2015 at 00:35, Marek Vasut <marex@denx.de> wrote:
> > On Thursday, October 22, 2015 at 08:21:29 PM, Jagan Teki wrote:
> >> On 22 October 2015 at 23:45, Marek Vasut <marex@denx.de> wrote:
> >> > On Thursday, October 22, 2015 at 07:45:49 PM, Jagan Teki wrote:
> >> >> BIT macro used on drivers/spi/*
> >> >>
> >> >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31
> >> >>
> >> >> Cc: Tom Rini <trini@konsulko.com>
> >> >> Cc: Simon Glass <sjg@chromium.org>
> >> >> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >> >> Cc: Peng Fan <Peng.Fan@freescale.com>
> >> >> Cc: Stefan Roese <sr@denx.de>
> >> >> Cc: Marek Vasut <marex@denx.de>
> >> >> Cc: Stephen Warren <swarren@nvidia.com>
> >> >> Cc: Tom Warren <twarren@nvidia.com>
> >> >> Signed-off-by: Jagan Teki <jteki@openedev.com>
> >> >
> >> > So, you're sending this horrid blob of changes instead of splitting
> >> > them into more managable parts, sigh. Moreover, I have a feeling this
> >> > is a change for the sake of changing something, not great. Also, you
> >> > did not describe how you performed this change -- was it done using
> >> > some sort of sed script or by hand ?
> >>
> >> Yes this is performed using sed
> >
> > The script you used should be explained somewhere.
>
> OK, add in next version patches.
>
> >> and as this a common change I have
> >> combined all spi drivers as I belongs to - did you see any wrong on
> >> this?
> >
> > It's hard to review such a big blob, furthermore if you need to adjust
> > some driver, you'd have to repost this whole thing instead of a single
> > patch.
>
> OK, then I will resend it separate patches, for individual drivers.

Also, please fix your mailer, you are constantly CCing Masahiro's old email
address for some reason. It's really annoying.

Best regards,
Marek Vasut