From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 24 Oct 2015 14:40:34 +0200 Subject: [U-Boot] [PATCH v5 20/23] spi: mxs_spi: Use GENMASK In-Reply-To: <1445657950-7117-21-git-send-email-jteki@openedev.com> References: <1445657950-7117-1-git-send-email-jteki@openedev.com> <1445657950-7117-21-git-send-email-jteki@openedev.com> Message-ID: <201510241440.34899.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, October 24, 2015 at 05:39:07 AM, Jagan Teki wrote: > Replace numeric mask hexcodes with GENMASK macro > in mxs_spi > > Cc: Marek Vasut > Signed-off-by: Jagan Teki > --- > drivers/spi/mxs_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c > index 627644b..459c603 100644 > --- a/drivers/spi/mxs_spi.c > +++ b/drivers/spi/mxs_spi.c > @@ -23,7 +23,7 @@ > > #define MXS_SPI_MAX_TIMEOUT 1000000 > #define MXS_SPI_PORT_OFFSET 0x2000 > -#define MXS_SSP_CHIPSELECT_MASK 0x00300000 > +#define MXS_SSP_CHIPSELECT_MASK GENMASK(21, 20) > #define MXS_SSP_CHIPSELECT_SHIFT 20 This is just making things unreadable, please keep it as is. NAK. Best regards, Marek Vasut