From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 24 Oct 2015 13:51:15 -0400 Subject: [U-Boot] [PATCH 04/13] include: Add ffs64 header file In-Reply-To: References: <1445689693-21436-1-git-send-email-festevam@gmail.com> <1445689693-21436-4-git-send-email-festevam@gmail.com> <20151024133207.GB23893@bill-the-cat> Message-ID: <20151024175115.GF23893@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Oct 24, 2015 at 12:54:40PM -0200, Fabio Estevam wrote: > On Sat, Oct 24, 2015 at 11:37 AM, Fabio Estevam wrote: > > Hi Tom, > > > > On Sat, Oct 24, 2015 at 11:32 AM, Tom Rini wrote: > >> On Sat, Oct 24, 2015 at 10:28:04AM -0200, Fabio Estevam wrote: > >> > >>> From: Fabio Estevam > >>> > >>> The ffs64() implementation for powerpc is not found in the Linux kernel, > >>> so use the ffs64 header file from barebox. > >>> > >>> Imported from barebox v2015.10.0. > >>> > >>> Signed-off-by: Fabio Estevam > >> > >> I'm confused. In the kernel __ffs64 is in , why do we > >> need to do things differently here? > > > > It is true that kernel uses __ffs64 from , however in > > U-boot (and barebox) there is also ffs64 for powerpc, so that's why I > > added a new header for it. > > > > We have no ffs64 in kernel, only __ffs64. > > After thinking more about it, I think we can simply use __ffs64 for > powerpc as well. > > There is no assembly optimzation for ffs64 so we can use the generic __ffs64. > > Will prepare a new version doing this. Thanks That's what I was hoping for, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: