From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Mon, 26 Oct 2015 14:00:29 +0200
Subject: [U-Boot] [PATCH 3/5] splash_source: add support for filesystem
 formatted usb
In-Reply-To: <562A3221.5070804@compulab.co.il>
References: <1440924156-11309-1-git-send-email-nikita@compulab.co.il>
 <1440924156-11309-4-git-send-email-nikita@compulab.co.il>
 <56278CBA.5080104@compulab.co.il> <20151023102338.GC11008@skynet>
 <562A3221.5070804@compulab.co.il>
Message-ID: <20151026120029.GA21801@skynet>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Oct 23, 2015 at 04:12:01PM +0300, Igor Grinberg wrote:
> On 10/23/15 13:23, Nikita Kiryanov wrote:
> > On Wed, Oct 21, 2015 at 04:01:46PM +0300, Igor Grinberg wrote:
> >> On 08/30/15 11:42, Nikita Kiryanov wrote:
> >>> Add support for loading splash image from USB drive formatted with a
> >>> filesystem.
> >>>
> >>> Cc: Igor Grinberg <grinberg@compulab.co.il>
> >>> Cc: Tom Rini <trini@konsulko.com>
> >>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> >>
> >> [...]
> >>
> >>> +#ifdef CONFIG_USB_STORAGE
> >>> +	if (location->storage == SPLASH_STORAGE_USB) {
> >>> +		usb_init();
> >>> +		usb_stor_scan(1);
> >>> +	}
> >>> +#endif
> >>
> >> Can we use IS_ENABLED() stuff here instead?
> > 
> > IS_ENABLED() does not prevent compile errors, only closes off certain
> > code paths.
> 
> Ok. Any other ways to not have that ifdefferry inside functions?

Well, I suppose I can take this out into its own function and stub it
#ifndef. I'll do a V2.

> 
> 
> -- 
> Regards,
> Igor.
>