[U-Boot] [PATCH V2 01/14] mxs: add parameter base_addr for mxs_set_lcdclk

Stefano Babic
2015-10-26T15:52:59Z

Hi Peng,

On 26/10/2015 03:57, Peng Fan wrote:
> Hi Stefano,
>
> Sorry for this late reply.
>
> On Tue, Oct 20, 2015 at 03:05:05PM +0200, Stefano Babic wrote:
>> Hi Peng,
>>
>>
>> On 20/10/2015 13:39, Peng Fan wrote:
>>> Change mxs_set_lcdclk prototype to add a new parameter
>>> base_addr. There are two LCD interfaces for i.MX6SX,
>>> we may support LCDIF1 or LCDIF2.
>>>
>>
>> ok - from your commit message I am waiting that both LCDIF1 and LCDIF2
>> can be supported, and a user (board maintainer) can switch between them.
>> And in later patch mxs_set_lcdclk() is avalilable for mx6sx and mx6ul,
>> that makes this inconsistent.
>
> I can not get you about 'inconsistent'.
>
> The reason to add LCDIF1 and LCDIF2
> support is that the board design may use LCDIF1 or LCDIF2. The mxs_set_lcdlck
> should support setting clock for LCDIF1 and LCDIF2.
>
> There two LCDIFs for i.MX6SX and i.MX7D.

This is fine, but I had the impression that the patch supports LCDIF1 on
mx6(sx|ul) and mx7, not LCDIF2. It looks like I have misunderstood. Can
you help me to better understand ? Does it really work with LCDIF2 ?

>
>>
>> But I do not understand how the support for the second LCDIF is
>> implemented. I should see that the register set points to LCDIF1 or LCDIF2.

Again this is the point I misunderstand.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================