From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 29 Oct 2015 14:16:52 +0100
Subject: [U-Boot] [PATCH] nios2: add 10m50 devboard support
In-Reply-To: <5631AFFF.70202@wytron.com.tw>
References: <1445818519-2004-1-git-send-email-thomas@wytron.com.tw>
 <201510290045.42299.marex@denx.de> <5631AFFF.70202@wytron.com.tw>
Message-ID: <201510291416.52921.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, October 29, 2015 at 06:34:55 AM, Thomas Chou wrote:
> Hi Marek,
> 
> On 10/29/2015 07:45 AM, Marek Vasut wrote:
> >> +# CONFIG_CMD_SETEXPR is not set
> > 
> > Please keep setexpr, it's really useful.
> 
> OK, I will keep it.
> 
> >> +/*
> >> + * MII/PHY
> >> + */
> >> +#define CONFIG_CMD_MII			1
> >> +#define CONFIG_PHY_GIGE			1
> >> +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN	1
> >> +#define CONFIG_PHY_MARVELL		1
> > 
> > Are you sure all these macros must have a value (1) ? I doubt it.
> 
> Oops, these '1' should be removed.
> 
> I will resend this patch after I finish the altera quadspi and altera
> tse msgdma update. Thank you.

Thanks!

Best regards,
Marek Vasut