[U-Boot] [PATCH] common: simply code

[U-Boot] [PATCH] common: simply code

[Peng Fan]

get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate
piece code. They can be merged into one snippet.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: "angelo at sysam.it" <angelo@sysam.it>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Stephen Warren <swarren@nvidia.com>
Cc: "Andreas Bie?mann" <andreas.devel@googlemail.com>
---
 common/board_f.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/common/board_f.c b/common/board_f.c
index 486e828..7bc05b1 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -806,10 +806,7 @@ static init_fnc_t init_sequence_f[] = {
 #if defined(CONFIG_BOARD_POSTCLK_INIT)
 	board_postclk_init,
 #endif
-#ifdef CONFIG_FSL_CLK
-	get_clocks,
-#endif
-#ifdef CONFIG_M68K
+#if defined(CONFIG_FSL_CLK) || defined(CONFIG_M68K)
 	get_clocks,
 #endif
 	env_init,		/* initialize environment */
-- 
1.8.4

[U-Boot] [PATCH] common: simply code

[Simon Glass]

On 29 October 2015 at 01:57, Peng Fan <Peng.Fan@freescale.com> wrote:
> get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate
> piece code. They can be merged into one snippet.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: "angelo at sysam.it" <angelo@sysam.it>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: "Andreas Bie?mann" <andreas.devel@googlemail.com>
> ---
>  common/board_f.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

nit: I think it would be better to use a subject like "common:
Simplify get_clocks() #ifdef".

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] common: simply code

[Peng Fan]

On Thu, Oct 29, 2015 at 11:15:51AM -0600, Simon Glass wrote:
>On 29 October 2015 at 01:57, Peng Fan <Peng.Fan@freescale.com> wrote:
>> get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate
>> piece code. They can be merged into one snippet.
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>> Cc: "angelo at sysam.it" <angelo@sysam.it>
>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>> Cc: Stephen Warren <swarren@nvidia.com>
>> Cc: "Andreas Bie?mann" <andreas.devel@googlemail.com>
>> ---
>>  common/board_f.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>
>nit: I think it would be better to use a subject like "common:
>Simplify get_clocks() #ifdef".

Thanks, will take your suggestion and send out v2.

Regards,
Peng.

>
>Reviewed-by: Simon Glass <sjg@chromium.org>

--