From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: reset: correct dma, qspi, and sdmmc reset bit defines
Date: Tue, 3 Nov 2015 04:33:13 +0100 [thread overview]
Message-ID: <201511030433.13165.marex@denx.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1511022110210.22097@linux-builds1>
On Tuesday, November 03, 2015 at 04:13:37 AM, Dinh Nguyen wrote:
> On Tue, 3 Nov 2015, Marek Vasut wrote:
> > On Tuesday, November 03, 2015 at 12:11:21 AM,
> > dinguyen at opensource.altera.com
> >
> > wrote:
> > > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> > >
> > > The DMA, QSPI, and SD/MMC reset bits are located in the permodrst
> > > register, not the mpumodrst. So the bank for these reset bits should
> > > be 1, not 0.
> > >
> > > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Thanks for finding this:
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > btw. how did you find this? I doubt it was some casual reading of the
> > source code :)
>
> I stumbled on this when I started adding the reset driver for Arria10, and
> did a quick code review.
Neat !
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-11-03 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 23:11 [U-Boot] [PATCH] arm: socfpga: reset: correct dma, qspi, and sdmmc reset bit defines dinguyen at opensource.altera.com
2015-11-03 2:16 ` Marek Vasut
2015-11-03 3:13 ` Dinh Nguyen
2015-11-03 3:33 ` Marek Vasut [this message]
2015-11-03 16:32 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511030433.13165.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox