From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 03/13] spl: mmc: refactor device location code to its own function
Date: Tue, 3 Nov 2015 10:56:18 -0500 [thread overview]
Message-ID: <20151103155618.GP8499@bill-the-cat> (raw)
In-Reply-To: <1446024210-16517-4-git-send-email-nikita@compulab.co.il>
On Wed, Oct 28, 2015 at 11:23:20AM +0200, Nikita Kiryanov wrote:
> Simplify spl_mmc_load_image() code by moving the part that finds the mmc device
> into its own function spl_mmc_find_device(), available in two flavors: DM and
> non-DM.
>
> This refactor fixes a bug in which an error in the device location sequence
> does not necessarily aborts the rest of the code. With this refactor, we fail
> the moment there is an error.
[snip]
> +#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> + puts("spl: could not find mmc device. error: %d\n", err);
> +#endif
Should be printf. And this reminds me that after we dug into things
before, there's really not a reason to use 'puts' sometimes and 'printf'
another, we can always just do printf and it doesn't actually change the
size.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151103/9145257f/attachment.sig>
next prev parent reply other threads:[~2015-11-03 15:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 9:23 [U-Boot] [PATCH V2 00/13] SPL mmc refactor and alternate boot device feature Nikita Kiryanov
2015-10-28 9:23 ` [U-Boot] [PATCH V2 01/13] spl: nand: remove code duplication Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-10-28 9:23 ` [U-Boot] [PATCH V2 02/13] spl: mmc: add break statements in spl_mmc_load_image() Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 03/13] spl: mmc: refactor device location code to its own function Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-10-31 15:25 ` Nikita Kiryanov
2015-11-03 15:56 ` Tom Rini [this message]
2015-10-28 9:23 ` [U-Boot] [PATCH V2 04/13] spl: mmc: remove #ifdef CONFIG_SPL_OS_BOOT check Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 05/13] spl: mmc: get rid of #ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION check Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 06/13] spl: mmc: move fs boot into its own function Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 07/13] spl: mmc: get rid of emmc boot code duplication Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 08/13] spl: change return values of spl_*_load_image() Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-10-31 15:44 ` Nikita Kiryanov
2015-11-03 12:19 ` [U-Boot] [PATCH V3 " Nikita Kiryanov
2015-11-03 15:56 ` Tom Rini
2015-11-06 3:16 ` Simon Glass
2015-10-28 9:23 ` [U-Boot] [PATCH V2 09/13] common: spl: move image load to its own function Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 10/13] spl: add support for alternative boot device Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-10-31 15:39 ` Nikita Kiryanov
2015-11-03 15:56 ` Tom Rini
2015-11-06 3:15 ` Simon Glass
2015-11-03 15:57 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 11/13] spl: announce boot devices Nikita Kiryanov
2015-10-29 17:19 ` Simon Glass
2015-11-03 12:10 ` Nikita Kiryanov
2015-11-03 12:20 ` [U-Boot] [PATCH V3 " Nikita Kiryanov
2015-11-03 15:56 ` Tom Rini
2015-10-28 9:23 ` [U-Boot] [PATCH V2 12/13] arm: mx6: cm-fx6: define fallback boot devices for spl Nikita Kiryanov
2015-11-03 15:57 ` Tom Rini
2015-11-04 9:47 ` Stefano Babic
2015-10-28 9:23 ` [U-Boot] [PATCH V2 13/13] spl: mmc: add support for BOOT_DEVICE_MMC2 Nikita Kiryanov
2015-11-03 15:57 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103155618.GP8499@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox