From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 6 Nov 2015 02:40:03 +0100 Subject: [U-Boot] [PATCH] nios2: nios2-generic: do not allocate rx buf in net.c In-Reply-To: <563BEA81.4070305@wytron.com.tw> References: <1446712963-32179-1-git-send-email-thomas@wytron.com.tw> <201511051716.11450.marex@denx.de> <563BEA81.4070305@wytron.com.tw> Message-ID: <201511060240.03312.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, November 06, 2015 at 12:47:13 AM, Thomas Chou wrote: > Hi Marek, Hi! > On 2015?11?06? 00:16, Marek Vasut wrote: > > On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote: > >> Do not allocate rx buf in net.c, because altera_tse allocates > >> its own rx buf in driver. This can save 6KB memory. > >> > >> Signed-off-by: Thomas Chou > > > > Shouldn't we instead fix the altera driver to use the pre-allocated > > buffer ? > > It should not. The drivers and devices are dynamically binding in driver > model. The buffers used by devices should be allocated per device. Eg, > there may be multiple ethernet devices and they should not use the same > pre-allocated rx bufs. Oh ok, I see your point now. But then, this allocation of buffers in the ethernet drivers becomes a boilerplate code, right ? So maybe there should be some mechanism in the network stack to allocate the buffers for the drivers to prevent duplication of code. What do you think? Best regards, Marek Vasut