From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 13 Nov 2015 07:41:43 +0100 Subject: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment In-Reply-To: <56442AC0.2030306@wytron.com.tw> References: <1447180247-29704-1-git-send-email-albert.u.boot@aribaud.net> <56442AC0.2030306@wytron.com.tw> Message-ID: <20151113074143.3f455341@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Thomas, On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou wrote: > Hi Albert, > - /* Update stack- and frame-pointers */ > - mov sp, r2 > - mov fp, sp Just a sec here on second thought. I understand the 'mov sp, r2' must be removed as it is replaced by a 'sub sp, sp, r2' a few lines earlier. But doesn't the 'mov fp, sp' need to remain? Without it, fp is not set any more, is it? > Best regards, > Thomas Amicalement, -- Albert.