From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
Date: Fri, 13 Nov 2015 08:13:42 +0100 [thread overview]
Message-ID: <201511130813.43082.marex@denx.de> (raw)
In-Reply-To: <56457F06.50209@denx.de>
On Friday, November 13, 2015 at 07:11:18 AM, Stefan Roese wrote:
> Hi Philipp,
>
> On 12.11.2015 18:23, Philipp Rosenberger wrote:
> > The Cyclone V Hard Processor System Technical Reference Manual in the
> > chapter about the Reset Manager Module Address Map stats that the offset
> > of the tstscratch register ist 0x54 not 0x24.
> >
> > Cyclone V Hard Processor System Technical Reference Manual cv_5v4
> > 2015.11.02 page 3-17 Reset Manager Module Address Map
> >
> > Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
> > ---
> >
> > arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > b/arch/arm/mach-socfpga/include/mach/reset_manager.h index
> > 8e59578..6eb6011 100644
> > --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
> >
> > u32 per2_mod_reset;
> > u32 brg_mod_reset;
> > u32 misc_mod_reset;
> >
> > + u32 padding2[12];
> >
> > u32 tstscratch;
> >
> > };
>
> Thanks. But usually such padding things are added as "u8" (1 byte)
> variables. This makes it easier to calculate the offsets. In this
> case:
>
> + u8 padding2[0x30];
>
> which I would prefer.
I don't mind either way, I can amend the patch (if you don't mind),
so let's hear Dinh's final word.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-11-13 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 17:23 [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register Philipp Rosenberger
2015-11-12 18:12 ` Marek Vasut
2015-11-12 21:58 ` Marek Vasut
2015-11-13 6:11 ` Stefan Roese
2015-11-13 7:13 ` Marek Vasut [this message]
2015-11-13 8:02 ` Philipp Rosenberger
2015-11-13 8:04 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511130813.43082.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox