public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment
Date: Fri, 13 Nov 2015 13:22:57 +0100	[thread overview]
Message-ID: <20151113132257.64f83d23@lilith> (raw)
In-Reply-To: <CAEUhbmUo7wZmu4cJ7=6JCCdP7edjZAm6yj4oJ333cqiVuiErOQ@mail.gmail.com>

Hello Bin,

On Fri, 13 Nov 2015 17:08:22 +0800, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Albert,
> 
> > +       subl    %esp, %eax
> 
> I guess you are confused by the AT&T assembly syntax. This should be:
> subl %eax, %esp.

> > +       subl    %esp, %eax
> 
> Ditto.

Thanks -- last time I touched Intel assembly was more than a decade
ago...

> > -       arch_setup_gd(gd_ptr);
> 
> This arch_setup_gd(gd_ptr) should not be deleted.

Correct.

> Regards,
> Bin

Thanks! These fixes will go in v3.

Amicalement,
-- 
Albert.

      reply	other threads:[~2015-11-13 12:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 18:30 [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment Albert ARIBAUD
2015-11-11  8:52 ` Albert ARIBAUD
2015-11-12  5:59 ` Thomas Chou
2015-11-12  7:17   ` Albert ARIBAUD
2015-11-12  8:28     ` Thomas Chou
2015-11-12 10:23       ` Albert ARIBAUD
2015-11-13  6:41   ` Albert ARIBAUD
2015-11-13  8:20     ` Thomas Chou
2015-11-13  9:08 ` Bin Meng
2015-11-13 12:22   ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151113132257.64f83d23@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox