From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Fri, 13 Nov 2015 13:22:57 +0100
Subject: [U-Boot] [PATCH v2] Fix board init code to use a valid C
 runtime environment
In-Reply-To: <CAEUhbmUo7wZmu4cJ7=6JCCdP7edjZAm6yj4oJ333cqiVuiErOQ@mail.gmail.com>
References: <1447180247-29704-1-git-send-email-albert.u.boot@aribaud.net>
 <CAEUhbmUo7wZmu4cJ7=6JCCdP7edjZAm6yj4oJ333cqiVuiErOQ@mail.gmail.com>
Message-ID: <20151113132257.64f83d23@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Bin,

On Fri, 13 Nov 2015 17:08:22 +0800, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Albert,
> 
> > +       subl    %esp, %eax
> 
> I guess you are confused by the AT&T assembly syntax. This should be:
> subl %eax, %esp.

> > +       subl    %esp, %eax
> 
> Ditto.

Thanks -- last time I touched Intel assembly was more than a decade
ago...

> > -       arch_setup_gd(gd_ptr);
> 
> This arch_setup_gd(gd_ptr) should not be deleted.

Correct.

> Regards,
> Bin

Thanks! These fixes will go in v3.

Amicalement,
-- 
Albert.