public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Fix board init code to use a valid C runtime environment
Date: Sun, 15 Nov 2015 19:31:17 +0100	[thread overview]
Message-ID: <20151115193117.1953c2ff@lilith> (raw)
In-Reply-To: <1447611925-4028-1-git-send-email-albert.u.boot@aribaud.net>

Hello Albert,

On Sun, 15 Nov 2015 19:25:25 +0100, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> board_init_f_mem() alters the C runtime environment's
> stack it ls actually already using. This is not a valid
> C runtime environment.
> 
> Split board_init_f_mem into C functions which do not
> alter their own stack and therefore run in a valid C
> runtime environment.

Of course, I only see the typos above now: that paragraph
should read:

	board_init_f_mem() alters the C runtime environment's
	stack it is actually already using. This is not a valid
	behaviour within a C runtime environment.

	Split board_init_f_mem into C functions which do not alter
	their own stack and always behave properly with respect to
	their C runtime environment.

If no comment calls for a v5, then whoever applies this v4 please fix
the commit message accordingly.

Amicalement,
-- 
Albert.

  reply	other threads:[~2015-11-15 18:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 18:25 [U-Boot] [PATCH v4] Fix board init code to use a valid C runtime environment Albert ARIBAUD
2015-11-15 18:31 ` Albert ARIBAUD [this message]
2015-11-16 13:12 ` Alexey Brodkin
2015-11-16 13:34   ` Albert ARIBAUD
2015-11-16 13:43     ` Alexey Brodkin
2015-11-16 14:15       ` Albert ARIBAUD
2015-11-16 14:22         ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151115193117.1953c2ff@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox