From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 15 Nov 2015 19:31:17 +0100 Subject: [U-Boot] [PATCH v4] Fix board init code to use a valid C runtime environment In-Reply-To: <1447611925-4028-1-git-send-email-albert.u.boot@aribaud.net> References: <1447611925-4028-1-git-send-email-albert.u.boot@aribaud.net> Message-ID: <20151115193117.1953c2ff@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Albert, On Sun, 15 Nov 2015 19:25:25 +0100, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it ls actually already using. This is not a valid > C runtime environment. > > Split board_init_f_mem into C functions which do not > alter their own stack and therefore run in a valid C > runtime environment. Of course, I only see the typos above now: that paragraph should read: board_init_f_mem() alters the C runtime environment's stack it is actually already using. This is not a valid behaviour within a C runtime environment. Split board_init_f_mem into C functions which do not alter their own stack and always behave properly with respect to their C runtime environment. If no comment calls for a v5, then whoever applies this v4 please fix the commit message accordingly. Amicalement, -- Albert.