From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/17] powerpc/km8321: set the DDRCDR impedance settings back to half strength
Date: Mon, 16 Nov 2015 08:34:45 -0500 [thread overview]
Message-ID: <20151116133445.GZ8060@bill-the-cat> (raw)
In-Reply-To: <5649CB8D.50808@keymile.com>
On Mon, Nov 16, 2015 at 01:26:53PM +0100, Holger Brunck wrote:
> Hi Valentin,
>
> On 13/11/15 15:59, Valentin Longchamp wrote:
> > The impedance settings have been changed with commit
> > 2ea8ae99595ca11dd228726e854ebc6268208601 (whose goal was to set
> > the internal voltage level to the DDR2 value - and not DDR1).
> >
>
> you are referencing the previous patch 09/17 here, shouldn't these two then not
> be squashed?
It's bad form to reference commit IDs of previous parts of a series as
they will not match what happens when commited to the tree so please say
the commit subject instead. And as Holger suggests, if this reference
patch 9/17 here, just squash the two together and v2 just that patch
please (assuming no further feedback on the series), thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151116/23beeb28/attachment.sig>
next prev parent reply other threads:[~2015-11-16 13:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 14:59 [U-Boot] [PATCH 00/17] km/powerpc: various bugfixes and support for 3 new boards Valentin Longchamp
2015-11-13 14:59 ` [U-Boot] [PATCH 01/17] powerpc/83xx/km: add support for kmvect1 p1a hw version Valentin Longchamp
2015-11-16 10:01 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 02/17] powerpc/83xx: add support for kmtepr2 board Valentin Longchamp
2015-11-16 10:01 ` Heiko Schocher
2015-11-16 12:18 ` Holger Brunck
2015-11-13 14:59 ` [U-Boot] [PATCH 03/17] powerpc/82xx: make set/get_pin for km82xx more flexible Valentin Longchamp
2015-11-16 10:06 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 04/17] powerpc/82xx/km: add testpin detection for mgcoge3ne Valentin Longchamp
2015-11-16 10:58 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 05/17] km/powerpc: increase space for kernel imange and FDT blob Valentin Longchamp
2015-11-16 10:58 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 06/17] km/powerpc: move open firmware defines to km-powerpc.h Valentin Longchamp
2015-11-16 10:59 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 07/17] km/powerpc: remove unneeded defines Valentin Longchamp
2015-11-16 11:00 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 08/17] km/powerpc82xx: remove unused function Valentin Longchamp
2015-11-16 11:01 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 09/17] powerpc/km8321: define CONFIG_SYS_DDRCDR Valentin Longchamp
2015-11-16 11:02 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 10/17] powerpc/km8321: set the DDRCDR impedance settings back to half strength Valentin Longchamp
2015-11-16 11:02 ` Heiko Schocher
2015-11-16 12:26 ` Holger Brunck
2015-11-16 13:34 ` Tom Rini [this message]
2015-11-16 15:41 ` Valentin Longchamp
2015-11-13 14:59 ` [U-Boot] [PATCH 11/17] powerpc/km8309: define CONFIG_SYS_DDRCDR Valentin Longchamp
2015-11-16 11:03 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 12/17] powerpc/km8360: fix the ODT parameters for CS0 Valentin Longchamp
2015-11-16 11:03 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 13/17] board/keymile/km82xx: setting dip_switch 3 and 4 will run bootloader Valentin Longchamp
2015-11-16 11:04 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 14/17] km83xx: use CONFIG_ENV_ADDR for the newenv env command Valentin Longchamp
2015-11-16 11:05 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 15/17] km8309: change the default QE_FW address Valentin Longchamp
2015-11-16 11:05 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 16/17] powerpc/83xx: add support for kmtegr1 board Valentin Longchamp
2015-11-16 11:06 ` Heiko Schocher
2015-11-13 14:59 ` [U-Boot] [PATCH 17/17] km/powerpc: fix ft_board_setup prototype for km82xx & km83xx Valentin Longchamp
2015-11-16 11:07 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116133445.GZ8060@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox