From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 20 Nov 2015 21:48:04 +0100
Subject: [U-Boot] [PATCH v2] usb: add support for generic EHCI devices
In-Reply-To: <1447860381-2645-1-git-send-email-abrodkin@synopsys.com>
References: <1447860381-2645-1-git-send-email-abrodkin@synopsys.com>
Message-ID: <201511202148.05092.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, November 18, 2015 at 04:26:21 PM, Alexey Brodkin wrote:
> This driver is meant to be used with any EHCI-compatible host
> controller in case if there's no need for platform-specific
> glue such as setup of controller or PHY's power mode via
> GPIOs etc.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
> 
> Changes compared to v1:
>  * Updated commit message with removal of Synopsys board mention
>  * Cleaned-up ehci_usb_remove()

[...]

> +static int ehci_usb_probe(struct udevice *dev)
> +{
> +	struct ehci_hccr *hccr = (struct ehci_hccr *)dev_get_addr(dev);
> +	struct ehci_hcor *hcor;
> +
> +	hcor = (struct ehci_hcor *)((uint32_t)hccr +

This should be uintptr_t for the sake of 64bit systems, no ?

> +				    HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> +
> +	return ehci_register(dev, hccr, hcor, NULL, 0, USB_INIT_HOST);
> +}

I can fix that nit when applying, so let me know what you think please.

Best regards,
Marek Vasut