From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/10] ARM: socfpga: arria10: add stub sdram init for Arria10
Date: Mon, 23 Nov 2015 13:57:28 +0100 [thread overview]
Message-ID: <201511231357.28217.marex@denx.de> (raw)
In-Reply-To: <20151123122539.GB5361@amd>
On Monday, November 23, 2015 at 01:25:39 PM, Pavel Machek wrote:
> Hi!
>
> > +union dramaddrw_reg {
> > + struct {
> > + u32 cfg_col_addr_width:5;
> > + u32 cfg_row_addr_width:5;
> > + u32 cfg_bank_addr_width:4;
> > + u32 cfg_bank_group_addr_width:2;
> > + u32 cfg_cs_addr_width:3;
> > + u32 reserved:13;
> > + };
> > + u32 word;
> > +};
>
> Umm. Are you sure this is good idea? Is gcc allowed to do something
> funny and reorder bitfields in unexpected way?
GCC won't do anything, but I cannot say I'm a big fan of those bitfields.
Let's just drop them and use the BIT() macro.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-11-23 12:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 21:35 [U-Boot] [PATCH 00/10] ARM: socfpga: Add minimal support for Arria10 dinguyen at opensource.altera.com
2015-11-19 21:35 ` [U-Boot] [PATCH 01/10] ARM: socfpga: arria10: add base address map " dinguyen at opensource.altera.com
2015-11-19 22:26 ` Marek Vasut
2015-11-23 23:16 ` Dinh Nguyen
2015-11-19 21:35 ` [U-Boot] [PATCH 02/10] ARM: socfpga: arria10: add system manager defines dinguyen at opensource.altera.com
2015-11-19 22:27 ` Marek Vasut
2015-11-19 21:35 ` [U-Boot] [PATCH 03/10] ARM: socfpga: arria10: add reset manager for Arria10 dinguyen at opensource.altera.com
2015-11-19 22:35 ` Marek Vasut
2015-11-19 21:35 ` [U-Boot] [PATCH 04/10] ARM: socfpga: arria10: add stub sdram init " dinguyen at opensource.altera.com
2015-11-23 12:25 ` Pavel Machek
2015-11-23 12:57 ` Marek Vasut [this message]
2015-11-19 21:35 ` [U-Boot] [PATCH 05/10] ARM: socfpga: arria10: add misc functions " dinguyen at opensource.altera.com
2015-11-19 22:37 ` Marek Vasut
2015-11-19 21:35 ` [U-Boot] [PATCH 06/10] ARM: socfpga: arria10: add socfpga_arria10_socdk config dinguyen at opensource.altera.com
2015-11-19 22:43 ` Marek Vasut
2015-11-19 21:35 ` [U-Boot] [PATCH 07/10] ARM: socfpga: arria10: add board files for the Arria10 SoCDK dinguyen at opensource.altera.com
2015-11-23 12:43 ` Pavel Machek
2015-11-19 21:35 ` [U-Boot] [PATCH 08/10] ARM: socfpga: arria10: add socfpga_arria10_defconfig dinguyen at opensource.altera.com
2015-11-19 21:35 ` [U-Boot] [PATCH 09/10] ARM: socfpga: arria10: add config option build for arria10 dinguyen at opensource.altera.com
2015-11-19 21:35 ` [U-Boot] [PATCH 10/10] ARM: socfpga: arria10: add support for building Arria10 dinguyen at opensource.altera.com
2015-11-19 22:45 ` Marek Vasut
2015-11-19 23:28 ` Dinh Nguyen
2015-11-20 12:49 ` Marek Vasut
2015-11-23 14:36 ` Dinh Nguyen
2015-11-23 15:38 ` Marek Vasut
2015-11-23 22:32 ` Dinh Nguyen
2015-11-23 22:46 ` Marek Vasut
2015-11-23 22:50 ` Dinh Nguyen
2015-11-23 23:03 ` Marek Vasut
2015-11-23 23:04 ` Dinh Nguyen
2015-11-23 23:20 ` Marek Vasut
2015-11-23 23:25 ` Dinh Nguyen
2015-11-24 3:17 ` Chin Liang See
2015-11-24 9:31 ` Marek Vasut
2015-11-24 12:29 ` Heiko Schocher
2015-11-24 9:33 ` Chin Liang See
2015-11-24 13:22 ` Chin Liang See
2015-11-24 13:31 ` Pavel Machek
2015-11-24 13:36 ` Chin Liang See
2015-11-24 13:52 ` Marek Vasut
2015-11-24 14:01 ` Pavel Machek
2015-11-24 15:09 ` Marek Vasut
2015-11-24 13:34 ` Chin Liang See
2015-11-24 13:53 ` Marek Vasut
2015-11-23 12:51 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511231357.28217.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox