From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 25 Nov 2015 00:31:02 +0100
Subject: [U-Boot] [PATCH V2] arm: novena: Switch novena to
	config_distro_bootcmd
In-Reply-To: <87k2p8zdpf.fsf@aikidev.net>
References: <1447191829-7997-1-git-send-email-marex@denx.de>
 <87k2p8zdpf.fsf@aikidev.net>
Message-ID: <201511250031.02330.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, November 23, 2015 at 09:02:36 PM, Vagrant Cascadian wrote:
> On 2015-11-10, Marek Vasut wrote:
> > Switch Novena to distro bootcmd, so it can be used with debian easily.
> > 
> > diff --git a/include/configs/novena.h b/include/configs/novena.h
> > index 718989f..3bb406d 100644
> > --- a/include/configs/novena.h
> > +++ b/include/configs/novena.h
> > @@ -58,7 +59,7 @@
> > 
> >  /* Booting Linux */
> >  #define CONFIG_BOOTFILE			"fitImage"
> >  #define CONFIG_BOOTARGS			"console=ttymxc1,115200 "
> > 
> > -#define CONFIG_BOOTCOMMAND		"run net_nfs"
> > +#define CONFIG_BOOTCOMMAND		"run distro_bootcmd ; run 
net_nfs"
> > 
> >  #define CONFIG_HOSTNAME			novena
> >  
> >  /* Physical Memory Map */
> 
> ...
> 
> > @@ -199,6 +201,10 @@
> > 
> >  	"rootdev=/dev/mmcblk0p2\0"					\
> >  	"netdev=eth0\0"							\
> >  	"kernel_addr_r="__stringify(CONFIG_LOADADDR)"\0"		\
> > 
> > +	"pxefile_addr_r="__stringify(CONFIG_LOADADDR)"\0"		\
> > +	"scriptaddr="__stringify(CONFIG_LOADADDR)"\0"			\
> > +	"ramdisk_addr_r=0x28000000\0"		   			\
> > +	"fdt_addr_r=0x10000000\0"					\
> > 
> >  	"addcons="							\
> >  	
> >  		"setenv bootargs ${bootargs} "				\
> >  		"console=${consdev},${baudrate}\0"			\
> 
> "fdtfile=imx6q-novena.dtb" should be added above, maybe after fdt_addr_r.

Added, thanks.

> The use of CONFIG_BOOTARGS and "run addcons" appear to be redundant, or
> at least overlapping. Other boards simply set "console=ttymxc0,115200"
> or appropriate, which would be a bit simpler.

Should be ttymxc1. The idea is that addcons let's you configure console using
the consdev and baudrate (which specifies the UART baudrate in u-boot too),
so if you change the baudrate in U-Boot, it is automatically updated in Linux
too.

Best regards,
Marek Vasut