public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel
Date: Fri, 27 Nov 2015 20:41:55 +0100	[thread overview]
Message-ID: <201511272041.55216.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ3e-3YqLLnadYKC+znHoNrS7DJq4nzfeDoKDzKAaTsDkQ@mail.gmail.com>

On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote:
> Hi,
> 
> On 26 November 2015 at 23:22, Chin Liang See <clsee@altera.com> wrote:
> > Enable SDMMC calibration to determine the best setting for
> > drvsel and smplsel. Calibration will be triggered if the
> > drvsel and smplsel node are not available in DTS.
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> > Changes for v4
> > - Calibration only run if node not in DTS
> > Changes for v3
> > - Remove the && ok as its redundant
> > Changes for v2
> > - Using standard error return macro
> > - Split to small function to avoid deep identation
> > - Fix coding standard
> > ---
> > 
> >  drivers/mmc/socfpga_dw_mmc.c | 208
> >  ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 205
> >  insertions(+), 3 deletions(-)
> 
> Should this code go in the generic dw_mmc.c file instead?

*Marek grabs popcorn*

You might want to read the discussion(s) below the previous versions of the 
patch, but TLDR, samsung doesn't want the calibration code to interfere with
their driver it seems.

Best regards,
Marek Vasut

  reply	other threads:[~2015-11-27 19:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  7:22 [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel Chin Liang See
2015-11-27 18:36 ` Simon Glass
2015-11-27 19:41   ` Marek Vasut [this message]
2015-11-29  1:59     ` Simon Glass
2015-11-29  2:05       ` Marek Vasut
2015-11-29 20:19         ` Simon Glass
2015-11-29 20:41           ` Marek Vasut
2015-11-29 13:39 ` Marek Vasut
2015-12-01 15:32   ` Chin Liang See
2015-12-01 15:38     ` Marek Vasut
2015-12-02  5:52       ` Chin Liang See
2015-12-02 14:39         ` Marek Vasut
2015-12-02 15:10           ` Chin Liang See
2015-12-02 15:43             ` Marek Vasut
2015-12-03 18:17           ` Pavel Machek
2016-01-27  0:01 ` Trent Piepho
2016-01-27 13:13   ` Chin Liang See
2016-01-27 18:58     ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201511272041.55216.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox