public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
Date: Sat, 28 Nov 2015 10:47:24 +0800	[thread overview]
Message-ID: <20151128024721.GA17975@shlinux2> (raw)
In-Reply-To: <1448543330-5975-1-git-send-email-marex@denx.de>

On Thu, Nov 26, 2015 at 02:08:50PM +0100, Marek Vasut wrote:
>The following patch changed the PFUZE100 swbst register bit definitions
>and broke PMIC configuration on multiple boards, at least on the novena
>and gw_ventana. This patch fixes it.
>
>commit 8fa46350a4c7dca7710362f6c871098557b934ad
>Author: Peng Fan <Peng.Fan@freescale.com>
>Date:   Fri Aug 7 16:43:45 2015 +0800
>
>    power: regulator: add pfuze100 support
>
>Signed-off-by: Marek Vasut <marex@denx.de>
>Cc: Fabio Estevam <fabio.estevam@freescale.com>
>Cc: Peng Fan <Peng.Fan@freescale.com>
>Cc: Przemyslaw Marczak <p.marczak@samsung.com>
>Cc: Stefano Babic <sbabic@denx.de>
>Cc: Tim Harvey <tharvey@gateworks.com>
>Cc: Vagrant Cascadian <vagrant@aikidev.net>
>---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c        | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
>index d406c83..a20190e 100644
>--- a/board/gateworks/gw_ventana/common.c
>+++ b/board/gateworks/gw_ventana/common.c
>@@ -806,7 +806,7 @@ void setup_pmic(void)
> 			/* Set SWBST to 5.0V and enable */
> 			pmic_reg_read(p, PFUZE100_SWBSTCON1, &reg);
> 			reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
>-			reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
>+			reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> 			pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> 		}
> 	}
>diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
>index babba85..b3159d3 100644
>--- a/board/kosagi/novena/novena.c
>+++ b/board/kosagi/novena/novena.c
>@@ -216,7 +216,7 @@ int power_init_board(void)
> 	/* Set SWBST to 5.0V and enable (for USB) */
> 	pmic_reg_read(p, PFUZE100_SWBSTCON1, &reg);
> 	reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
>-	reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
>+	reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> 	pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> 
> 	return 0;

Reviewed-by: Peng Fan <Peng.Fan@freescale.com>

>-- 
>2.1.4
>

-- 

  parent reply	other threads:[~2015-11-28  2:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
2015-11-26 16:18 ` Przemyslaw Marczak
2015-11-27 20:18 ` Vagrant Cascadian
2015-11-28  2:47 ` Peng Fan [this message]
2015-11-30  9:53 ` Przemyslaw Marczak
2015-11-30 10:00   ` Stefano Babic
2015-11-30 10:13     ` Przemyslaw Marczak
2015-11-30 16:32 ` Tim Harvey
2015-12-01 15:10 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151128024721.GA17975@shlinux2 \
    --to=b51431@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox