* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
@ 2015-11-26 16:18 ` Przemyslaw Marczak
2015-11-27 20:18 ` Vagrant Cascadian
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Przemyslaw Marczak @ 2015-11-26 16:18 UTC (permalink / raw)
To: u-boot
Hello Marek,
On 11/26/2015 02:08 PM, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
> index d406c83..a20190e 100644
> --- a/board/gateworks/gw_ventana/common.c
> +++ b/board/gateworks/gw_ventana/common.c
> @@ -806,7 +806,7 @@ void setup_pmic(void)
> /* Set SWBST to 5.0V and enable */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> }
> }
> diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
> index babba85..b3159d3 100644
> --- a/board/kosagi/novena/novena.c
> +++ b/board/kosagi/novena/novena.c
> @@ -216,7 +216,7 @@ int power_init_board(void)
> /* Set SWBST to 5.0V and enable (for USB) */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
>
> return 0;
>
Thanks for fixing :)
Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
2015-11-26 16:18 ` Przemyslaw Marczak
@ 2015-11-27 20:18 ` Vagrant Cascadian
2015-11-28 2:47 ` Peng Fan
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Vagrant Cascadian @ 2015-11-27 20:18 UTC (permalink / raw)
To: u-boot
On 2015-11-26, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
Works on novena.
Tested-by: Vagrant Cascadian <vagrant@aikidev.net>
live well,
vagrant
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
> index d406c83..a20190e 100644
> --- a/board/gateworks/gw_ventana/common.c
> +++ b/board/gateworks/gw_ventana/common.c
> @@ -806,7 +806,7 @@ void setup_pmic(void)
> /* Set SWBST to 5.0V and enable */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> }
> }
> diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
> index babba85..b3159d3 100644
> --- a/board/kosagi/novena/novena.c
> +++ b/board/kosagi/novena/novena.c
> @@ -216,7 +216,7 @@ int power_init_board(void)
> /* Set SWBST to 5.0V and enable (for USB) */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
>
> return 0;
> --
> 2.1.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151127/c1ca47cd/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
2015-11-26 16:18 ` Przemyslaw Marczak
2015-11-27 20:18 ` Vagrant Cascadian
@ 2015-11-28 2:47 ` Peng Fan
2015-11-30 9:53 ` Przemyslaw Marczak
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2015-11-28 2:47 UTC (permalink / raw)
To: u-boot
On Thu, Nov 26, 2015 at 02:08:50PM +0100, Marek Vasut wrote:
>The following patch changed the PFUZE100 swbst register bit definitions
>and broke PMIC configuration on multiple boards, at least on the novena
>and gw_ventana. This patch fixes it.
>
>commit 8fa46350a4c7dca7710362f6c871098557b934ad
>Author: Peng Fan <Peng.Fan@freescale.com>
>Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
>Signed-off-by: Marek Vasut <marex@denx.de>
>Cc: Fabio Estevam <fabio.estevam@freescale.com>
>Cc: Peng Fan <Peng.Fan@freescale.com>
>Cc: Przemyslaw Marczak <p.marczak@samsung.com>
>Cc: Stefano Babic <sbabic@denx.de>
>Cc: Tim Harvey <tharvey@gateworks.com>
>Cc: Vagrant Cascadian <vagrant@aikidev.net>
>---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
>index d406c83..a20190e 100644
>--- a/board/gateworks/gw_ventana/common.c
>+++ b/board/gateworks/gw_ventana/common.c
>@@ -806,7 +806,7 @@ void setup_pmic(void)
> /* Set SWBST to 5.0V and enable */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
>- reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
>+ reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> }
> }
>diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
>index babba85..b3159d3 100644
>--- a/board/kosagi/novena/novena.c
>+++ b/board/kosagi/novena/novena.c
>@@ -216,7 +216,7 @@ int power_init_board(void)
> /* Set SWBST to 5.0V and enable (for USB) */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
>- reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
>+ reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
>
> return 0;
Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
>--
>2.1.4
>
--
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
` (2 preceding siblings ...)
2015-11-28 2:47 ` Peng Fan
@ 2015-11-30 9:53 ` Przemyslaw Marczak
2015-11-30 10:00 ` Stefano Babic
2015-11-30 16:32 ` Tim Harvey
2015-12-01 15:10 ` Stefano Babic
5 siblings, 1 reply; 9+ messages in thread
From: Przemyslaw Marczak @ 2015-11-30 9:53 UTC (permalink / raw)
To: u-boot
Hello Stefano,
On 11/26/2015 02:08 PM, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Will you pick-up this patch, or should it go through PMIC tree?
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-30 9:53 ` Przemyslaw Marczak
@ 2015-11-30 10:00 ` Stefano Babic
2015-11-30 10:13 ` Przemyslaw Marczak
0 siblings, 1 reply; 9+ messages in thread
From: Stefano Babic @ 2015-11-30 10:00 UTC (permalink / raw)
To: u-boot
On 30/11/2015 10:53, Przemyslaw Marczak wrote:
> Hello Stefano,
>
> On 11/26/2015 02:08 PM, Marek Vasut wrote:
>> The following patch changed the PFUZE100 swbst register bit definitions
>> and broke PMIC configuration on multiple boards, at least on the novena
>> and gw_ventana. This patch fixes it.
>>
>> commit 8fa46350a4c7dca7710362f6c871098557b934ad
>> Author: Peng Fan <Peng.Fan@freescale.com>
>> Date: Fri Aug 7 16:43:45 2015 +0800
>>
>> power: regulator: add pfuze100 support
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Peng Fan <Peng.Fan@freescale.com>
>> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Tim Harvey <tharvey@gateworks.com>
>> Cc: Vagrant Cascadian <vagrant@aikidev.net>
>> ---
>> board/gateworks/gw_ventana/common.c | 2 +-
>> board/kosagi/novena/novena.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Will you pick-up this patch, or should it go through PMIC tree?
They are i.MXes, I pick them up.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-30 10:00 ` Stefano Babic
@ 2015-11-30 10:13 ` Przemyslaw Marczak
0 siblings, 0 replies; 9+ messages in thread
From: Przemyslaw Marczak @ 2015-11-30 10:13 UTC (permalink / raw)
To: u-boot
On 11/30/2015 11:00 AM, Stefano Babic wrote:
> On 30/11/2015 10:53, Przemyslaw Marczak wrote:
>> Hello Stefano,
>>
>> On 11/26/2015 02:08 PM, Marek Vasut wrote:
>>> The following patch changed the PFUZE100 swbst register bit definitions
>>> and broke PMIC configuration on multiple boards, at least on the novena
>>> and gw_ventana. This patch fixes it.
>>>
>>> commit 8fa46350a4c7dca7710362f6c871098557b934ad
>>> Author: Peng Fan <Peng.Fan@freescale.com>
>>> Date: Fri Aug 7 16:43:45 2015 +0800
>>>
>>> power: regulator: add pfuze100 support
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>>> Cc: Peng Fan <Peng.Fan@freescale.com>
>>> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Tim Harvey <tharvey@gateworks.com>
>>> Cc: Vagrant Cascadian <vagrant@aikidev.net>
>>> ---
>>> board/gateworks/gw_ventana/common.c | 2 +-
>>> board/kosagi/novena/novena.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Will you pick-up this patch, or should it go through PMIC tree?
>
> They are i.MXes, I pick them up.
>
> Best regards,
> Stefano
>
>
Ok, thank you.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
` (3 preceding siblings ...)
2015-11-30 9:53 ` Przemyslaw Marczak
@ 2015-11-30 16:32 ` Tim Harvey
2015-12-01 15:10 ` Stefano Babic
5 siblings, 0 replies; 9+ messages in thread
From: Tim Harvey @ 2015-11-30 16:32 UTC (permalink / raw)
To: u-boot
On Thu, Nov 26, 2015 at 5:08 AM, Marek Vasut <marex@denx.de> wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
> board/gateworks/gw_ventana/common.c | 2 +-
> board/kosagi/novena/novena.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/gateworks/gw_ventana/common.c b/board/gateworks/gw_ventana/common.c
> index d406c83..a20190e 100644
> --- a/board/gateworks/gw_ventana/common.c
> +++ b/board/gateworks/gw_ventana/common.c
> @@ -806,7 +806,7 @@ void setup_pmic(void)
> /* Set SWBST to 5.0V and enable */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
> }
> }
> diff --git a/board/kosagi/novena/novena.c b/board/kosagi/novena/novena.c
> index babba85..b3159d3 100644
> --- a/board/kosagi/novena/novena.c
> +++ b/board/kosagi/novena/novena.c
> @@ -216,7 +216,7 @@ int power_init_board(void)
> /* Set SWBST to 5.0V and enable (for USB) */
> pmic_reg_read(p, PFUZE100_SWBSTCON1, ®);
> reg &= ~(SWBST_MODE_MASK | SWBST_VOL_MASK);
> - reg |= (SWBST_5_00V | SWBST_MODE_AUTO);
> + reg |= (SWBST_5_00V | (SWBST_MODE_AUTO << SWBST_MODE_SHIFT));
> pmic_reg_write(p, PFUZE100_SWBSTCON1, reg);
>
> return 0;
> --
> 2.1.4
>
Acked-by: Tim Harvey <tharvey@gateworks.com>
Thanks Marek!
Tim
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions
2015-11-26 13:08 [U-Boot] [PATCH] arm: imx6: novena, gw_ventana: Fix use of pfuze100 bit definitions Marek Vasut
` (4 preceding siblings ...)
2015-11-30 16:32 ` Tim Harvey
@ 2015-12-01 15:10 ` Stefano Babic
5 siblings, 0 replies; 9+ messages in thread
From: Stefano Babic @ 2015-12-01 15:10 UTC (permalink / raw)
To: u-boot
On 26/11/2015 14:08, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date: Fri Aug 7 16:43:45 2015 +0800
>
> power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
Applied to u-boot-imx, thanks!
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread