From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 29 Nov 2015 14:35:41 +0100 Subject: [U-Boot] [PATCH 2/2] altera_qspi: fix erase and write error code In-Reply-To: <1448797103-30524-2-git-send-email-thomas@wytron.com.tw> References: <1448797103-30524-1-git-send-email-thomas@wytron.com.tw> <1448797103-30524-2-git-send-email-thomas@wytron.com.tw> Message-ID: <201511291435.41378.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday, November 29, 2015 at 12:38:23 PM, Thomas Chou wrote: > Fix erase and write error code, which should be "protected". Can you elaborate on why do you think this change is correct please ? That reasoning should be part of the patch description. > Signed-off-by: Thomas Chou > --- > drivers/mtd/altera_qspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c > index 89f04a4..cf45e73 100644 > --- a/drivers/mtd/altera_qspi.c > +++ b/drivers/mtd/altera_qspi.c > @@ -77,7 +77,7 @@ int flash_erase(flash_info_t *info, int s_first, int > s_last) instr.len = mtd->erasesize * (s_last + 1 - s_first); > ret = mtd_erase(mtd, &instr); > if (ret) > - return ERR_NOT_ERASED; > + return ERR_PROTECTED; > > return 0; > } > @@ -94,7 +94,7 @@ int write_buff(flash_info_t *info, uchar *src, ulong > addr, ulong cnt) > > ret = mtd_write(mtd, to, cnt, &retlen, src); > if (ret) > - return ERR_NOT_ERASED; > + return ERR_PROTECTED; > > return 0; > } Best regards, Marek Vasut