* [U-Boot] [PATCH] imx: mx6: add missing return value
@ 2015-11-29 17:30 Jeroen Hofstee
2015-11-30 1:46 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Jeroen Hofstee @ 2015-11-29 17:30 UTC (permalink / raw)
To: u-boot
cc: Peng Fan <Peng.Fan@freescale.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
not tested ;)
arch/arm/cpu/armv7/mx6/clock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
index 67e0f32..4f6fe86 100644
--- a/arch/arm/cpu/armv7/mx6/clock.c
+++ b/arch/arm/cpu/armv7/mx6/clock.c
@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
reg = readl(&imx_ccm->CCGR2);
reg |= MXC_CCM_CCGR2_LCD_MASK;
writel(reg, &imx_ccm->CCGR2);
+
+ return 0;
}
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx: mx6: add missing return value
2015-11-29 17:30 [U-Boot] [PATCH] imx: mx6: add missing return value Jeroen Hofstee
@ 2015-11-30 1:46 ` Peng Fan
2015-11-30 10:17 ` Stefano Babic
2015-12-07 13:59 ` Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2015-11-30 1:46 UTC (permalink / raw)
To: u-boot
Hi Jeroen,
On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>cc: Peng Fan <Peng.Fan@freescale.com>
>Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>---
>not tested ;)
>
> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>index 67e0f32..4f6fe86 100644
>--- a/arch/arm/cpu/armv7/mx6/clock.c
>+++ b/arch/arm/cpu/armv7/mx6/clock.c
>@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
> reg = readl(&imx_ccm->CCGR2);
> reg |= MXC_CCM_CCGR2_LCD_MASK;
> writel(reg, &imx_ccm->CCGR2);
>+
>+ return 0;
I CCed i.MX branch maintainer for you.
Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
Regards,
Peng.
> }
> #endif
>
>--
>1.9.1
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx: mx6: add missing return value
2015-11-30 1:46 ` Peng Fan
@ 2015-11-30 10:17 ` Stefano Babic
2015-12-07 13:59 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-11-30 10:17 UTC (permalink / raw)
To: u-boot
On 30/11/2015 02:46, Peng Fan wrote:
> Hi Jeroen,
> On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>> cc: Peng Fan <Peng.Fan@freescale.com>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> not tested ;)
>>
>> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>> index 67e0f32..4f6fe86 100644
>> --- a/arch/arm/cpu/armv7/mx6/clock.c
>> +++ b/arch/arm/cpu/armv7/mx6/clock.c
>> @@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
>> reg = readl(&imx_ccm->CCGR2);
>> reg |= MXC_CCM_CCGR2_LCD_MASK;
>> writel(reg, &imx_ccm->CCGR2);
>> +
>> + return 0;
>
> I CCed i.MX branch maintainer for you.
>
> Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
>
Thanks.
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx: mx6: add missing return value
2015-11-30 1:46 ` Peng Fan
2015-11-30 10:17 ` Stefano Babic
@ 2015-12-07 13:59 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-12-07 13:59 UTC (permalink / raw)
To: u-boot
On 30/11/2015 02:46, Peng Fan wrote:
> Hi Jeroen,
> On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>> cc: Peng Fan <Peng.Fan@freescale.com>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> not tested ;)
>>
>> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>> index 67e0f32..4f6fe86 100644
>> --- a/arch/arm/cpu/armv7/mx6/clock.c
>> +++ b/arch/arm/cpu/armv7/mx6/clock.c
>> @@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
>> reg = readl(&imx_ccm->CCGR2);
>> reg |= MXC_CCM_CCGR2_LCD_MASK;
>> writel(reg, &imx_ccm->CCGR2);
>> +
>> + return 0;
>
> I CCed i.MX branch maintainer for you.
>
> Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-07 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-29 17:30 [U-Boot] [PATCH] imx: mx6: add missing return value Jeroen Hofstee
2015-11-30 1:46 ` Peng Fan
2015-11-30 10:17 ` Stefano Babic
2015-12-07 13:59 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox