public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22
Date: Mon, 30 Nov 2015 11:37:37 -0500	[thread overview]
Message-ID: <20151130163737.GW9551@bill-the-cat> (raw)
In-Reply-To: <1448899605.3032.5.camel@perches.com>

On Mon, Nov 30, 2015 at 08:06:45AM -0800, Joe Perches wrote:
> On Mon, 2015-11-30 at 10:56 -0500, Tom Rini wrote:
> > On Mon, Nov 30, 2015 at 10:23:20AM +0000, Alexey Brodkin wrote:
> []
> > > Similar fix is already in Linus' master tree, see
> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/comm
> > > it/?id=4e5d56bdf892e18832a6540b63ebf709966bce2a
> > > 
> > > Also note:
> > >  [1] That commit from Linux tree won't apply cleanly on U-Boot
> > >      due to a bit different context.
> > >  [2] Even if manually tweaked it looks like it is incomplete:
> > >      ------------------->8-------------------
> > >      )\(.*\).*\s{ <-- HERE /@scripts/checkpatch.pl line 2828.
> > >      ------------------->8-------------------
> > > 
> > > So with above in mind could you please apply that patch posted by
> > > Moritz?
> > > 
> > > This fixes checkpatch in Fedora 23 - in current state it is way too
> > > noisy.
> > 
> > Maybe we just need to re-sync again?
> 
> I don't track u-boot.
> 
> Are there any u-boot specific changes made to checkpatch
> that are inappropriate for the linux-kernel?
> 
> If there aren't, maybe whatever u-boot changes that have
> been made to checkpatch should be pulled into the kernel
> version.

My memory is hazy, sorry, so I dug this up:
https://lkml.org/lkml/2014/2/24/542 and then re-read most of it.  I had
a newer version of the __packed check that I didn't post (I'm pretty
sure) since the general feedback seemed to be that it wasn't wanted for
the kernel.  Other than that (and some other tiny things that are easy
to fixup) no, we don't have local changes.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151130/1770a909/attachment.sig>

      reply	other threads:[~2015-11-30 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 19:25 [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22 Moritz Fischer
2015-09-03 19:32 ` Joe Perches
2015-09-03 20:46 ` Joe Hershberger
2015-11-30 10:23   ` Alexey Brodkin
2015-11-30 15:56     ` Tom Rini
2015-11-30 15:57       ` Alexey Brodkin
2015-11-30 16:02         ` Tom Rini
2015-11-30 16:05           ` Alexey Brodkin
2015-11-30 16:06       ` Joe Perches
2015-11-30 16:37         ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130163737.GW9551@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox