From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 1 Dec 2015 18:11:22 +0100
Subject: [U-Boot] [PATCH v3 2/2] usb: eth: add Realtek RTL8152B/RTL8153
	driver
In-Reply-To: <565DCB62.5070509@wwwdotorg.org>
References: <1448429454-8640-1-git-send-email-tedchen@realtek.com>
 <201512011610.14794.marex@denx.de> <565DCB62.5070509@wwwdotorg.org>
Message-ID: <201512011811.22901.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, December 01, 2015 at 05:31:30 PM, Stephen Warren wrote:
> On 12/01/2015 08:10 AM, Marek Vasut wrote:
> > On Tuesday, December 01, 2015 at 12:24:41 PM, Ted Chen wrote:
> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB
> >> network adapters.
> > 
> > Hi!
> > 
> > looks pretty good, just a few final nitpicks below.
> > 
> >> Signed-off-by: Ted Chen <tedchen@realtek.com>
> >> [swarren, fixed a few compiler warnings]
> >> [swarren, with permission, converted license header to SPDX]
> >> [swarren, removed printf() spew during probe()]
> > 
> > This changelog should be removed, really. It doesn't have to be in the
> > commit message, right ?
> 
> In general it's good practice when people edit someone else's patch to
> note that in the patch description so that it's obvious who to blame for
> what.
> 
> However in this particular case an exception could likely be made since
> the original patch author has taken over the patch again and made
> significantly more changes than listed above.

OK, whichever way you prefer then.

Best regards,
Marek Vasut