From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 1 Dec 2015 19:41:05 +0100 Subject: [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10 In-Reply-To: <565DD500.8090706@denx.de> References: <1448988115-20700-1-git-send-email-dinguyen@opensource.altera.com> <565DD500.8090706@denx.de> Message-ID: <201512011941.05669.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, December 01, 2015 at 06:12:32 PM, Stefan Roese wrote: > On 01.12.2015 17:41, dinguyen at opensource.altera.com wrote: > > From: Dinh Nguyen > > > > Add remaining 3 I2C base addresses for the Arria10. > > > > Signed-off-by: Dinh Nguyen > > --- > > > > arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h index > > a7056d4..8653dd5 100644 > > --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h > > @@ -29,6 +29,10 @@ > > > > #define SOCFPGA_MPUL2_ADDRESS 0xfffff000 > > #define SOCFPGA_I2C0_ADDRESS 0xffc02200 > > #define SOCFPGA_I2C1_ADDRESS 0xffc02300 > > > > +#define SOCFPGA_I2C2_ADDRESS 0xffc02400 > > +#define SOCFPGA_I2C3_ADDRESS 0xffc02500 > > +#define SOCFPGA_I2C4_ADDRESS 0xffc02600 > > + > > > > #define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000 > > #define SOCFPGA_UART0_ADDRESS 0xffc02000 > > Nitpicking, but there seems to be one empty line too much > added above. > > Other than this: > > Reviewed-by: Stefan Roese > > BTW: Is anyone working on DM conversion of this I2C driver? All > those macros for the base addresses would not be needed then. Fixed and applied. Best regards, Marek Vasut