public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] arm: socfpga: introduce SOCFPGA_GEN5 or SOCFPGA_GEN10
Date: Wed, 2 Dec 2015 00:31:59 +0100	[thread overview]
Message-ID: <201512020031.59528.marex@denx.de> (raw)
In-Reply-To: <1449007202-5980-1-git-send-email-dinguyen@opensource.altera.com>

On Tuesday, December 01, 2015 at 11:00:02 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and
> SOCFPGA_GEN10 for Arria10 hardware.
> 
> This would allow us to use the shorten define in the rest of code.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
>  include/configs/socfpga_common.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index 3374683..8fc5666 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -6,6 +6,11 @@
>  #ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
>  #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
> 
> +#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) ||
> defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5
> +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10)
> +#define SOCFPGA_GEN10
> +#endif

The same thing can be done in arch/arm/mach-socfpga/Kconfig -- introduce
blank symbol similar to TARGET_SOCFPGA_CYCLONE5 and make both of the
TARGET_SOCFPGA_CYCLONE5 and TARGET_SOCFPGA_ARRIA5 select it. But do you
think it's worth it ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-01 23:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 22:00 [U-Boot] [RFC] arm: socfpga: introduce SOCFPGA_GEN5 or SOCFPGA_GEN10 dinguyen at opensource.altera.com
2015-12-01 23:31 ` Marek Vasut [this message]
2015-12-01 23:37   ` Dinh Nguyen
2015-12-02  0:18     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512020031.59528.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox