[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Pavel Machek]

CONFIG_PHYLIB is already set by the config system, don't set it again.
Avoids ton of warnings.
    
Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index b3f65b6..86eccba 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -105,7 +105,6 @@
 #define CONFIG_DW_ALTDESCRIPTOR
 #define CONFIG_MII
 #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
-#define CONFIG_PHYLIB
 #define CONFIG_PHY_GIGE
 #endif
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Marek Vasut]

On Saturday, December 05, 2015 at 08:50:39 AM, Pavel Machek wrote:
> CONFIG_PHYLIB is already set by the config system

Where exactly is it set by the config system ?

> don't set it again.
> Avoids ton of warnings.

Sorry, I don't seem to be able to replicate these warnings. Can you provide
more details ?

> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index b3f65b6..86eccba 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -105,7 +105,6 @@
>  #define CONFIG_DW_ALTDESCRIPTOR
>  #define CONFIG_MII
>  #define CONFIG_AUTONEG_TIMEOUT		(15 * CONFIG_SYS_HZ)
> -#define CONFIG_PHYLIB
>  #define CONFIG_PHY_GIGE
>  #endif

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Pavel Machek]

On Sat 2015-12-05 15:04:25, Marek Vasut wrote:
> On Saturday, December 05, 2015 at 08:50:39 AM, Pavel Machek wrote:
> > CONFIG_PHYLIB is already set by the config system
> 
> Where exactly is it set by the config system ?
> 
> > don't set it again.
> > Avoids ton of warnings.
> 
> Sorry, I don't seem to be able to replicate these warnings. Can you provide
> more details ?

U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .

pavel at duo:~/amp/u-boot$ grep -ri PHYLIB `find . -name "Kconfig"`
./drivers/net/Kconfig:config PHYLIB
./drivers/net/Kconfig:	     select PHYLIB
./drivers/net/Kconfig:	       100Mbit and 1 Gbit operation. You must
enable CONFIG_PHYLIB to
./drivers/net/Kconfig:	select PHYLIB

ALTERA_TSE selects it.

Let me know if you need more info.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Marek Vasut]

On Saturday, December 05, 2015 at 06:25:19 PM, Pavel Machek wrote:
> On Sat 2015-12-05 15:04:25, Marek Vasut wrote:
> > On Saturday, December 05, 2015 at 08:50:39 AM, Pavel Machek wrote:
> > > CONFIG_PHYLIB is already set by the config system
> > 
> > Where exactly is it set by the config system ?
> > 
> > > don't set it again.
> > > Avoids ton of warnings.
> > 
> > Sorry, I don't seem to be able to replicate these warnings. Can you
> > provide more details ?
> 
> U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .
> 
> pavel at duo:~/amp/u-boot$ grep -ri PHYLIB `find . -name "Kconfig"`
> ./drivers/net/Kconfig:config PHYLIB
> ./drivers/net/Kconfig:	     select PHYLIB
> ./drivers/net/Kconfig:	       100Mbit and 1 Gbit operation. You must
> enable CONFIG_PHYLIB to
> ./drivers/net/Kconfig:	select PHYLIB
> 
> ALTERA_TSE selects it.

Altera TSE is not selected on any socfpga platform to my knowledge.
Could it be your patch which is causing the interference ?

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Pavel Machek]

On Sat 2015-12-05 18:54:01, Marek Vasut wrote:
> On Saturday, December 05, 2015 at 06:25:19 PM, Pavel Machek wrote:
> > On Sat 2015-12-05 15:04:25, Marek Vasut wrote:
> > > On Saturday, December 05, 2015 at 08:50:39 AM, Pavel Machek wrote:
> > > > CONFIG_PHYLIB is already set by the config system
> > > 
> > > Where exactly is it set by the config system ?
> > > 
> > > > don't set it again.
> > > > Avoids ton of warnings.
> > > 
> > > Sorry, I don't seem to be able to replicate these warnings. Can you
> > > provide more details ?
> > 
> > U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .
> > 
> > pavel at duo:~/amp/u-boot$ grep -ri PHYLIB `find . -name "Kconfig"`
> > ./drivers/net/Kconfig:config PHYLIB
> > ./drivers/net/Kconfig:	     select PHYLIB
> > ./drivers/net/Kconfig:	       100Mbit and 1 Gbit operation. You must
> > enable CONFIG_PHYLIB to
> > ./drivers/net/Kconfig:	select PHYLIB
> > 
> > ALTERA_TSE selects it.
> 
> Altera TSE is not selected on any socfpga platform to my knowledge.
> Could it be your patch which is causing the interference ?

Ok, that explains why you don't see it. I have ALTERA_TSE
enabled. ... which is probably useless, but still should not cause ton
of warnings.

Question is: how to solve it properly?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Marek Vasut]

On Saturday, December 05, 2015 at 07:03:36 PM, Pavel Machek wrote:
> On Sat 2015-12-05 18:54:01, Marek Vasut wrote:
> > On Saturday, December 05, 2015 at 06:25:19 PM, Pavel Machek wrote:
> > > On Sat 2015-12-05 15:04:25, Marek Vasut wrote:
> > > > On Saturday, December 05, 2015 at 08:50:39 AM, Pavel Machek wrote:
> > > > > CONFIG_PHYLIB is already set by the config system
> > > > 
> > > > Where exactly is it set by the config system ?
> > > > 
> > > > > don't set it again.
> > > > > Avoids ton of warnings.
> > > > 
> > > > Sorry, I don't seem to be able to replicate these warnings. Can you
> > > > provide more details ?
> > > 
> > > U-boot based on be30dfbabbee12770221f434d2aa08627e712b97 .
> > > 
> > > pavel at duo:~/amp/u-boot$ grep -ri PHYLIB `find . -name "Kconfig"`
> > > ./drivers/net/Kconfig:config PHYLIB
> > > ./drivers/net/Kconfig:	     select PHYLIB
> > > ./drivers/net/Kconfig:	       100Mbit and 1 Gbit operation. You must
> > > enable CONFIG_PHYLIB to
> > > ./drivers/net/Kconfig:	select PHYLIB
> > > 
> > > ALTERA_TSE selects it.
> > 
> > Altera TSE is not selected on any socfpga platform to my knowledge.
> > Could it be your patch which is causing the interference ?
> 
> Ok, that explains why you don't see it. I have ALTERA_TSE
> enabled. ... which is probably useless, but still should not cause ton
> of warnings.
> 
> Question is: how to solve it properly?

Ccing Joe.

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: Don't redefine CONFIG_PHYLIB

[Thomas Chou]

Hi Marek and Pavel,

>> Ok, that explains why you don't see it. I have ALTERA_TSE
>> enabled. ... which is probably useless, but still should not cause ton
>> of warnings.

The CONFIG_PHYLIB in socfpga_common.h should be moved to Kconfig. I will 
send a patch.

Best regards,
Thomas