From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/3] spl: mmc: Unify non/driver model spl_mmc_find_device()
Date: Sun, 6 Dec 2015 17:07:52 -0500 [thread overview]
Message-ID: <20151206220752.GX9551@bill-the-cat> (raw)
In-Reply-To: <1449079153-25422-4-git-send-email-sjg@chromium.org>
On Wed, Dec 02, 2015 at 10:59:13AM -0700, Simon Glass wrote:
> It is risky to have two different functions with much the same code. Future
> authors may update one but not the other. It is hard to see which parts are
> the same and which are different.
>
> Unify the functions and drop the differences that are not really needed.
>
> Note that one puts() becomes printf() as Tom mentioned that this does not
> affect image size:
>
> https://patchwork.ozlabs.org/patch/537276/
>
> Note: It would be better to have an empty printf() and avoid the #ifdef for
> CONFIG_SPL_LIBCOMMON_SUPPORT.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151206/13a46752/attachment.sig>
prev parent reply other threads:[~2015-12-06 22:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 17:59 [U-Boot] [PATCH v3 0/3] spl: mmc: Fix warning and unify spl_mmc_find_device() Simon Glass
2015-12-02 17:59 ` [U-Boot] [PATCH v3 1/3] spl: mmc: Fix compiler warning with CONFIG_DM_MMC Simon Glass
2015-12-03 9:28 ` Nikita Kiryanov
2015-12-06 22:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-12-02 17:59 ` [U-Boot] [PATCH v3 2/3] spl: mmc: Rename 'mmc' variable to 'mmcp' Simon Glass
2015-12-06 22:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-12-02 17:59 ` [U-Boot] [PATCH v3 3/3] spl: mmc: Unify non/driver model spl_mmc_find_device() Simon Glass
2015-12-06 22:07 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151206220752.GX9551@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox